Skip to content

Commit 59c7ff1

Browse files
EtienneLescotclaude
andcommitted
docs(ci): correct the include-hidden-files rationale in docs.yml
The comment added in 7c4827b claims Docusaurus writes a `.nojekyll` into website/build, and justifies `include-hidden-files: true` as restoring it. That is wrong: Docusaurus only writes `.nojekyll` from its own `deploy` command, not from a plain `build`. The Pages artifact published by that very commit (id 9028339047) was unpacked and contains 59 entries and no dot-entries at all, so the flag is currently a no-op. Keep the flag, fix the reason. Preserving the v3 default matters for what comes later, not for what is there now: a `.well-known/` added for domain verification or security.txt would be dropped from the deploy silently under the v4+ default, and that failure is invisible until someone checks why the verification never completes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 7c4827b commit 59c7ff1

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

‎.github/workflows/docs.yml‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,11 +60,15 @@ jobs:
6060
uses: actions/upload-pages-artifact@fc324d3547104276b827a68afc52ff2a11cc49c9 # v5.0.0
6161
with:
6262
path: website/build
63-
# v4 stopped bundling dotfiles, and Docusaurus writes a `.nojekyll`
64-
# into website/build. The artifact-based Pages deploy never runs
65-
# Jekyll, so losing it would probably be harmless — but "probably" is
66-
# not worth finding out on the live site, and this restores exactly
67-
# what v3 uploaded. `.git`/`.github` stay excluded either way.
63+
# v4 stopped bundling dotfiles by default. Nothing in website/build
64+
# is hidden today — the deployed artifact from 7c4827b9 was checked
65+
# and contains no dot-entries at all, so this changes nothing now
66+
# (Docusaurus only writes a `.nojekyll` on its own `deploy` command,
67+
# not in a plain `build`). It is set so that stays true by accident
68+
# rather than by omission: a `.well-known/` for domain verification
69+
# or security.txt is the realistic case, and under the v4+ default it
70+
# would vanish from the deploy silently. `.git` and `.github` are
71+
# excluded regardless of this flag.
6872
include-hidden-files: true
6973

7074
deploy:

0 commit comments

Comments
 (0)