Skip to content

proposal: remove logger pkg #93

Description

@alexanderbez

We have a logger package that contains an abstraction over Go's standard slog logger. I do not see a benefit in having an interface/abstraction over slog for the following reasons:

  1. slog (as of Go 1.26) can support multiple writers on a single logger (being released this month Feb)
  2. We have no foreseeable interest in ever supporting a different logger other than slog
  3. The DX in the interface is actually a bit clunky, i.e. I'd prefer and argue it's cleaner and simpler to read logger.Error("...", "err", err, "val", 4) instead of logger.Error("...", err, logger.With*(...)). In other words, just provide the variadic fields; logger.With*(...) is not necessary and just makes the code verbose.

cc @hpsing @abergasov

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

DXdeveloper experience

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions