Skip to content

Commit 01457db

Browse files
mydeaclaude
andcommitted
test(e2e): Remove event dumps and their normalization script
The Next.js apps dumped all envelopes to `event-dumps/`, which CI uploaded on failure after normalizing transactions into span trees. The normalization has not found any dumps since E2E apps moved to a temp directory, and it doesn't understand streamed spans. Nobody relies on the dumps, so drop the feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 64925fb commit 01457db

31 files changed

Lines changed: 1 addition & 309 deletions

File tree

‎.github/workflows/build.yml‎

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1174,21 +1174,6 @@ jobs:
11741174
overwrite: true
11751175
retention-days: 7
11761176

1177-
- name: Pre-process E2E Test Dumps
1178-
if: failure()
1179-
run: |
1180-
node ./scripts/normalize-e2e-test-dump-transaction-events.js ${{ runner.temp }}/test-application/event-dumps
1181-
1182-
- name: Upload E2E Test Event Dumps
1183-
uses: actions/upload-artifact@v7
1184-
if: failure()
1185-
with:
1186-
name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
1187-
path: ${{ runner.temp }}/test-application/event-dumps
1188-
overwrite: true
1189-
retention-days: 7
1190-
if-no-files-found: ignore
1191-
11921177
# - We skip optional tests on release branches
11931178
job_optional_e2e_tests:
11941179
name: E2E ${{ matrix.label || matrix.test-application }} Test (optional)
@@ -1302,21 +1287,6 @@ jobs:
13021287
timeout-minutes: 10
13031288
run: ${{ matrix.assert-command || 'pnpm test:assert' }}
13041289

1305-
- name: Pre-process E2E Test Dumps
1306-
if: failure()
1307-
run: |
1308-
node ./scripts/normalize-e2e-test-dump-transaction-events.js ${{ runner.temp }}/test-application/event-dumps
1309-
1310-
- name: Upload E2E Test Event Dumps
1311-
uses: actions/upload-artifact@v7
1312-
if: failure()
1313-
with:
1314-
name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
1315-
path: ${{ runner.temp }}/test-application/event-dumps
1316-
overwrite: true
1317-
retention-days: 7
1318-
if-no-files-found: ignore
1319-
13201290
job_required_jobs_passed:
13211291
name: All required jobs passed or were skipped
13221292
needs:

‎dev-packages/e2e-tests/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"ci:build-matrix-optional": "node ./lib/getTestMatrix.mjs --optional=true",
1616
"ci:copy-to-temp": "node ./ciCopyToTemp.mjs",
1717
"ci:pnpm-overrides": "node ./ciPnpmOverrides.mjs",
18-
"clean:test-applications": "rimraf --glob test-applications/**/{node_modules,dist,build,.next,.nuxt,.sveltekit,.react-router,.astro,.output,pnpm-lock.yaml,.last-run.json,test-results,.angular,event-dumps}",
18+
"clean:test-applications": "rimraf --glob test-applications/**/{node_modules,dist,build,.next,.nuxt,.sveltekit,.react-router,.astro,.output,pnpm-lock.yaml,.last-run.json,test-results,.angular}",
1919
"clean:pnpm": "pnpm store prune"
2020
},
2121
"devDependencies": {

‎dev-packages/e2e-tests/test-applications/cloudflare-think/start-event-proxy.mjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@ import { startEventProxyServer } from '@sentry-internal/test-utils';
33
startEventProxyServer({
44
port: 3031,
55
proxyServerName: 'cloudflare-think',
6-
envelopeDumpPath: process.env.SENTRY_ENVELOPE_DUMP_PATH,
76
});

‎dev-packages/e2e-tests/test-applications/nextjs-14/.gitignore‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,3 @@ next-env.d.ts
4343
.vscode
4444

4545
test-results
46-
event-dumps
Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
1-
import * as fs from 'fs';
2-
import * as path from 'path';
31
import { startEventProxyServer } from '@sentry-internal/test-utils';
42

5-
const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json')));
6-
73
startEventProxyServer({
84
port: 3031,
95
proxyServerName: 'nextjs-14',
10-
envelopeDumpPath: path.join(
11-
process.cwd(),
12-
`event-dumps/next-14-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`,
13-
),
146
});

‎dev-packages/e2e-tests/test-applications/nextjs-15-basepath/.gitignore‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,5 @@ next-env.d.ts
4343
.vscode
4444

4545
test-results
46-
event-dumps
4746

4847
.tmp_dev_server_logs
Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
1-
import * as fs from 'fs';
2-
import * as path from 'path';
31
import { startEventProxyServer } from '@sentry-internal/test-utils';
42

5-
const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json')));
6-
73
startEventProxyServer({
84
port: 3031,
95
proxyServerName: 'nextjs-15-basepath',
10-
envelopeDumpPath: path.join(
11-
process.cwd(),
12-
`event-dumps/next-15-basepath-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`,
13-
),
146
});

‎dev-packages/e2e-tests/test-applications/nextjs-15-intl/.gitignore‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,5 @@ pnpm-lock.yaml
4646
.tmp_dev_server_logs
4747
.tmp_build_stdout
4848
.tmp_build_stderr
49-
event-dumps
5049
test-results
5150

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,6 @@
1-
import * as fs from 'fs';
2-
import * as path from 'path';
31
import { startEventProxyServer } from '@sentry-internal/test-utils';
42

5-
const packageJson = JSON.parse(fs.readFileSync(path.join(process.cwd(), 'package.json')));
6-
73
startEventProxyServer({
84
port: 3031,
95
proxyServerName: 'nextjs-15-intl',
10-
envelopeDumpPath: path.join(
11-
process.cwd(),
12-
`event-dumps/nextjs-15-intl-v${packageJson.dependencies.next}-${process.env.TEST_ENV}.dump`,
13-
),
146
});

‎dev-packages/e2e-tests/test-applications/nextjs-15/.gitignore‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,5 @@ next-env.d.ts
4343
.vscode
4444

4545
test-results
46-
event-dumps
4746

4847
.tmp_dev_server_logs

0 commit comments

Comments
 (0)