Error message

[croghostrider]

Hi
if I try to run the binwalk or the yara script I receive the following message in the console:

yara.py> Running...
CRC32_poly_Constant /root/winbin/test.exe
Failed
'NoneType' object has no attribute 'setComment'
yara.py> Finished!

[ettermyra]

Got the same 'NoneType' object has no attribute 'setComment' error for the binwalk extension
Running Ghidra 9.0.2

[citizenstaar]

Got the same error. Running Ghidra 9.1

[Te-k]

Same here with Ghidra 9.1.2.

The error come from a bad conversion from physical address to logical address : yara returns a physical address in the binary, while you need the logical address to add bookmark and comment. The conversion here addr = currentProgram.minAddress.add(addr_int) does not work

[Te-k]

I have opened a ticket to check with Ghidra devs if there is a way to do that NationalSecurityAgency/ghidra#2067

[CarlOlson]

Same issue on Ghidra 9.2

yara.py> Running...
Found : Big_Numbers0 - 0xdadb97 - 0x140db0197L
Traceback (most recent call last):
  File "/home/carl/git/ghidra_scripts/yara.py", line 53, in <module>
    add_bookmark_comment(vaddr, current_rule)
  File "/home/carl/git/ghidra_scripts/yara.py", line 30, in add_bookmark_comment
    cu.setComment(CodeUnit.EOL_COMMENT, text)
AttributeError: 'NoneType' object has no attribute 'setComment'
yara.py> Finished!

It works if I change yara.py:30 to this:

currentProgram.getListing().setComment(gaddr, CodeUnit.EOL_COMMENT, text)