Exposing functions for decoding and encoding enums

[sporto]

Given that squirrel already creates functions for decoding and encoding enums.
I would like to use them somewhere else. e.g. If I want to use those enums in a url query string.

Current output from squirrel:

pub type BookingStatus {
  BookingCancelled
  BookingConfirmed
  BookingHeld
  BookingStarted
}

fn booking_status_decoder() {
  use variant <- decode.then(decode.string)
  case variant {
    "booking_cancelled" -> decode.success(BookingCancelled)
    "booking_confirmed" -> decode.success(BookingConfirmed)
    "booking_held" -> decode.success(BookingHeld)
    "booking_started" -> decode.success(BookingStarted)
    _ -> decode.failure(BookingCancelled, "BookingStatus")
  }
}

fn booking_status_encoder(variant) {
  case variant {
    BookingCancelled -> "booking_cancelled"
    BookingConfirmed -> "booking_confirmed"
    BookingHeld -> "booking_held"
    BookingStarted -> "booking_started"
  }
  |> pog.text
}

The functions are private and specific to sql.

It would like to have:

pub type BookingStatus {
  BookingCancelled
  BookingConfirmed
  BookingHeld
  BookingStarted
}

pub fn booking_status_from_code(code) {
  case code {
    "booking_cancelled" -> Ok(BookingCancelled)
    "booking_confirmed" -> Ok(BookingConfirmed)
    "booking_held" -> Ok(BookingHeld)
    "booking_started" -> Ok(BookingStarted)
    _ -> Error("Invalid " <> code)
  }
}

pub fn booking_status_to_code(variant) {
  case variant {
    BookingCancelled -> "booking_cancelled"
    BookingConfirmed -> "booking_confirmed"
    BookingHeld -> "booking_held"
    BookingStarted -> "booking_started"
  }
}

fn booking_status_decoder() {
  use variant <- decode.then(decode.string)
  case booking_status_from_code(variant) {
    Ok(variant) -> decode.success(variant)
    _ -> decode.failure(BookingCancelled, "BookingStatus")
  }
}

fn booking_status_encoder(variant) {
 booking_status_to_code(variant)
  |> pog.text
}

i.e. expose some functions to decoding and encoding enums. e.g. booking_status_from_code and booking_status_to_code. This functions are used for the current encoding and decoding private functions.

Thanks

[giacomocavalieri]

Hello! I'm turning this into a discussion as it's the first time this comes up and I'd like to hear from more folks before making this change to the public API :)