Config static calls on non-static methods.

[dasper]

Config class is being called statically when the methods are not static and have no default configurations.

In PHP 7, calling non-static methods statically is deprecated, and will generate an E_DEPRECATED warning. Support for calling non-static methods statically may be removed in the future.

Also, I am not sure if Config should be configured to be called statically since you need to supply values for the configuration so not many, if any, would be out of object context. I can work on a pull request but I am unsure of the direction you are wanting to take with the project.

[tanftw]

Thanks for reporting.

I set private methods so it hidden from static call. For example Config::get(); will call magic method, instead of private method, then in magic method, it create new instance and call that private method. Will it break on PHP 7?

Best regards,

Gary

[tanftw]

Btw, for default configuration, users can create a file, and use Config::loadFromFile() method

[dasper]

I believe the magic method __callStatic() is intended for when the method does not exist. In PHP 7, since the method would have already been defined, __callStatic() will not be invoked.

Also, on this point I could be wrong, I think if you are calling a method static, you are saying this method does not require you to instantiate the object. So if someone needs to load custom configurations, then it will require the class to be loaded since any static call will only be able to load the default configurations. Any changed data would technically make it dynamic.

[tanftw]

I'll double check my environment since I use Valet to develop Giga AI.

The class is singleton so it can be access with both static and non static type. The purpose of instance is to allows users access the class via $bot->config->get() and $bot->config->set() methods. Without using this, users have to use GigaAI\Core\Config::get() and GigaAI\Core\Config::set() in their callback function which harder to remember.

Cheers!