Commit b70612f
committed
review fixes for v0.63.0
Caught during self-review of the nine polish items:
1. Recovery notice handled negative age ("-1 min ago") from clock skew or
very fresh snapshots. Added "just now" branch for age < 1 minute.
2. Shortcuts overlay Diff Preview entries were invented:
- Enter was documented as "Apply" but diff actually uses y / Y
- "r: Reject" never existed (diff uses n / N / Esc)
- "Tab: Toggle context lines" is wrong — Tab only toggles focus in the
multi-file variant, and is unbound in single-file diff
- "e: Edit before applying" was aspirational — no key handler exists
Replaced with the real bindings: y, n/Esc, A, R, Tab (multi-only).
3. Error guidance regexes used bare HTTP status codes (401, 500, etc.)
which would match "500ms latency" or any substring. Added \b word
boundaries; 5xx now also requires a nearby keyword (error/server/
gateway/unavailable/timeout) so random numbers don't trigger.
4. Tool progress bar truncation sliced by bytes, not runes. For Cyrillic
or emoji output this could produce invalid UTF-8 before appending "…".
Now converts to []rune before slicing.1 parent 5e060e0 commit b70612f
4 files changed
Lines changed: 20 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
434 | 434 | | |
435 | 435 | | |
436 | 436 | | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
437 | 440 | | |
438 | 441 | | |
439 | 442 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
274 | 274 | | |
275 | 275 | | |
276 | 276 | | |
277 | | - | |
| 277 | + | |
| 278 | + | |
278 | 279 | | |
279 | | - | |
| 280 | + | |
280 | 281 | | |
281 | 282 | | |
282 | 283 | | |
283 | 284 | | |
284 | 285 | | |
285 | 286 | | |
286 | | - | |
| 287 | + | |
287 | 288 | | |
288 | 289 | | |
289 | 290 | | |
290 | 291 | | |
291 | | - | |
| 292 | + | |
292 | 293 | | |
293 | | - | |
| 294 | + | |
294 | 295 | | |
295 | 296 | | |
296 | 297 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
69 | | - | |
70 | | - | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
71 | 73 | | |
72 | 74 | | |
73 | 75 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
160 | | - | |
161 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
162 | 165 | | |
163 | 166 | | |
164 | 167 | | |
| |||
0 commit comments