user:redact enhancement

[rkawala]

If I do user:adduser=rkawala|password-hash=big-long-hash|redact I was thinking that would keep my password hash value from being echoed in the progress output that sdm --customize echoes to the screen, and that I capture persistently using script(1). If I saw

* Plugins selected:
  * user
      Args: adduser=rkawala|password-hash=redacted|redact| (the rest of the args)

that'd keep my password hash from hitting the disk.

[rkawala]

I know I'm creating a lot of discussions recently, each one potentially increasing your workload. I want you to know that I'm just suggesting, not demanding.

[gitbls]

No worries. The fact that the password hash isn't being redacted is a bug. It must be crushed. Unless it's too complex to do so.

[rkawala]

Maybe there ought to be a new option --redact-passwords-only so that I don't have to manually redact passwords, but the log will contain all the other plugin information. I have a memory that --redact doesn't print any of the plugin arguments, which is too much redaction. I only want to redact the foo part of password-hash=foo.

[gitbls]

I finally got a break from all your other requests 🤣🤣🤣 and looked into the redaction. For the user plugin if you want passwords and password hashes to be hidden, use a userlist. The lines are appropriately redacted when processed.

That said, there is a bug there in that password-hash and password-plain arguments are not properly redacted, but soon will be, as will the info message that overshares.

[rkawala]

How about something like sdm --customize --redact-field user:password-hash so that I could state which field(s) I didn't want to see?

[gitbls]

Please grab the latest user plugin from master for a spin