Improving generated Go code to comply with go lint rules, in order …#34
Open
derFunk wants to merge 1 commit into
Open
Improving generated Go code to comply with go lint rules, in order …#34derFunk wants to merge 1 commit into
go lint rules, in order …#34derFunk wants to merge 1 commit into
Conversation
…to avoid massive warnings from generated code: - Avoid excessive underscores in names, instead use CamelCase. - Add comments to public structs to avoid warnings about missing ones. - Use uppercase representations for common initialisms (there are more, not yet integrated here: https://github.com/golang/lint/blob/master/lint.go#L749) - Setting default value of `keepXmlFirstLetterCase` to `false`, because it's enabled by setting the `-K` cli argument.
Owner
|
I will take a look at this over the next few days :-) Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…to avoid massive warnings from generated code:
keepXmlFirstLetterCasetofalse, because it's enabled by setting the-Kcli argument.