Skip to content

Confusing comment in smallerThan implementation #103

Description

@josojo

From Lasse:

For smallerThan in IterableOrderedOrderSet.sol there seem to be a mismatch between comment and the implementation, the comment says that it is ordered by: price, sellAmount and then userId, but from the implementation, it looks at the priceNumerator after the price.

While technically everything is correct, as we are sorting buy sellAmount and buyAmount (in this case of the code, we have: sellAmountLeft < sellAmountRight, if and only if buyAmountLeft < buyAmountRight) this comment is still confusing and should be corrected.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions