Fix the expectNotVisible assertion to properly handle 0 elements present#105
Merged
Merged
Conversation
tanyafortuna
changed the title
Collaborator
Author
|
@belsrc @brandonjpierce another one for you, a small bugfix to make the |
belsrc
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
expectNotVisibleassertion was intended to pass (and documented as such) when:And it should fail if there is exactly 1 element and it's visible, or if there are 2+ elements of any visibility.
The bug is that the code currently only passes if there is exactly 1 invisible element, and the 0 elements case isn't covered.
This bugfix adds the second condition so it will properly pass if the element isn't there at all.