Improve visibility pairing validation #108
Open
tanyafortuna wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
@brandonjpierce @belsrc another one for you. This PR improves visibility validation (making sure something is visible -> action gets taken -> it's invisible, or vice versa) by counting actual actions between visibility checks instead of requiring the assertions to be exactly two lines apart. |
tanyafortuna
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the visibility assertion validation to allow multiple elements to change visibility from a single action.
Previously, the validator required visibility checks to be exactly 2 steps apart (check -> action -> check), which could be quite limiting.
Now it groups assertions by target and counts only actions between pairs, ignoring other assertions. This enables test scenarios where multiple elements appear or disappear from one user action, like clicking a toggle that shows/hides several UI components at once.