Skip to content

URLs with a '-' do not work for cookieRewrites #55

@kristiehoward

Description

@kristiehoward

We are trying to use your cookieRewrite functionality in order to pass cookies back through our proxy from our staging server to localhost. Our staging URL looks like name-stage.otherName.com, which does not match the regex /(Domain)=[a-z\.-_]*?(;|$)/gi in https://github.com/andrewrk/node-proxy-middleware/blob/master/index.js#L110. This blocks the cookieRewrite from actually happening.

Is there a reason you have excluded URLs with a - in them? If not, please update the regex to match URLs such as myurl-stage.com. I can put out a PR if you want :) we used /(Domain)=[a-z\.-_-]*?(;|$)/gi locally.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions