Skip to content

Commit 88564e0

Browse files
authored
Fix invocations of saferpickle within the CLI
Additionally, added saferpickle and safer_pickle to the denylist
2 parents 5df16f7 + 7a6c107 commit 88564e0

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

cli.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,15 +64,15 @@ def security_scan_with_justifications(
6464

6565
# Call the individual scan functions from SaferPickle to sets of results.
6666
# Picklemagic Scan
67-
picklemagic_results = safer_pickle.picklemagic_scan(pickle_bytes)
67+
picklemagic_results = saferpickle.picklemagic_scan(pickle_bytes)
6868

6969
safe_results.update(picklemagic_results.safe_results)
7070
unsafe_results.update(picklemagic_results.unsafe_results)
7171
suspicious_results.update(picklemagic_results.suspicious_results)
7272
unknown_results.update(picklemagic_results.unknown_results)
7373

7474
# Genops Scan
75-
genops_results = safer_pickle.genops_scan(
75+
genops_results = saferpickle.genops_scan(
7676
pickle_bytes, pickle_file_path=file_path
7777
)
7878
safe_results.update(genops_results.safe_results)
@@ -97,15 +97,15 @@ def security_scan_with_justifications(
9797
num_unsafe,
9898
num_suspicious,
9999
_, # The unknown_score is not used for classification, only reporting
100-
) = safer_pickle.score_results(
100+
) = saferpickle.score_results(
101101
final_safe_results,
102102
final_unsafe_results,
103103
final_suspicious_results,
104104
final_unknown_results,
105105
)
106106

107107
# Check for safety and return the results with justifications.
108-
if safer_pickle.is_unsafe(num_safe, num_unsafe, num_suspicious):
108+
if saferpickle.is_unsafe(num_safe, num_unsafe, num_suspicious):
109109
if num_unsafe > num_suspicious:
110110
classification = "unsafe"
111111
all_results = []

lib/constants.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@
134134
"read",
135135
"requests",
136136
"runpy",
137-
"safer_pickle_hook",
137+
"safer_pickle",
138+
"saferpickle",
138139
"socket",
139140
"ssl",
140141
"stdin",

lib/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
"""Utility functions for safer_pickle."""
15+
"""Utility functions for saferpickle."""
1616

1717
import ast
1818
import bz2

0 commit comments

Comments
 (0)