Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Confusing instruction on using proto js package #118

@jasonclg

Description

@jasonclg

According to the note in https://github.com/googleapis/api-common-protos#packages

Note that if using these packages, you will still need a local copy of these protos when using protoc, but you will not need to ship compiled versions of them. (This is consistent with protoc's default behavior of only providing compiled output for the files specifically requested, and not their imports.)

This does not seem right for js package.
I protoc compiled my proto file with those imports from google-proto-files.
Apparently I have to ship compiled version of imported protos too because the google-proto-files does not contain them (unlike the packages for other languages or imports from google/protobuf/).

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority: p3Desirable enhancement or fix. May not be included in next release.type: questionRequest for information or clarification. Not an issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions