-
Notifications
You must be signed in to change notification settings - Fork 57
Open
Labels
api: loggingIssues related to the googleapis/python-logging API.Issues related to the googleapis/python-logging API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
google.cloud.logging_v2 contains a py.typed file but the package does not provide type annotations.
Hence, code like this:
from google.cloud.logging import Client
from google.cloud.logging.handlers import CloudLoggingHandler
from google.cloud.logging_v2.handlers.handlers import setup_logging
client = Client()
handler = CloudLoggingHandler(client)
setup_logging(handler)will trigger this error in Pyright:
test.py:3:55 - error: Type of "setup_logging" is partially unknown
Type of "setup_logging" is "(handler: Unknown, *, excluded_loggers: Unknown = EXCLUDED_LOGGER_DEFAULTS, log_level: int = logging.INFO) -> None" (reportUnknownVariableType)
My interpretation of the meaning of py.typed is "this package has type annotations that should be use by the type checker for code importing this package".
Is there any plan to provide type annotations?
Metadata
Metadata
Assignees
Labels
api: loggingIssues related to the googleapis/python-logging API.Issues related to the googleapis/python-logging API.priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.