refactor: remove yaml mention dependency from trigger pipeline

Author: gqy20

.github/workflows/orchestrator.yml

@@ -103,8 +103,15 @@ jobs:
           FOUND_AGENTS=$(python - <<'PY'
           import os
           import re
+          import sys
           from pathlib import Path
 
+          src_path = Path.cwd() / "src"
+          if src_path.exists():
+            sys.path.insert(0, str(src_path))
+
+          from issuelab.utils.mentions import extract_controlled_mentions
+
           comment = os.environ.get("COMMENT_BODY", "")
           agents_dir = Path("agents")
 
@@ -137,26 +144,7 @@ jobs:
               system_agents.add(owner_match.group(1).strip().lower())
 
           found: list[str] = []
-          controlled_lines: list[str] = []
-          in_list_section = False
-          for raw_line in comment.splitlines():
-            line = raw_line.strip()
-            if "相关人员:" in line:
-              controlled_lines.append(line.split("相关人员:", 1)[1])
-              in_list_section = False
-              continue
-            if line.startswith("协作请求:"):
-              in_list_section = True
-              continue
-            if in_list_section:
-              if re.match(r"^\s*-\s+@", raw_line):
-                controlled_lines.append(raw_line)
-                continue
-              if line and not line.startswith("-"):
-                in_list_section = False
-
-          controlled_text = "\n".join(controlled_lines)
-          for mention in re.findall(r"@([a-zA-Z0-9_-]+)", controlled_text):
+          for mention in extract_controlled_mentions(comment):
             candidate = mention.lower()
             if candidate in system_agents and candidate not in found:
               found.append(candidate)

config/response_format.yml

@@ -22,11 +22,7 @@ limits:
   actions_max_chars: 160
   mentions_max_count: 5
 
-rules:
-  mentions_only_in_actions: true
-  yaml_required: true
-
 notes:
-  - mentions is required when you want to notify others; it must be a list of GitHub usernames (without @).
-  - do not use @mentions in the free-text body; use the mentions field instead.
+  - mentions are parsed from controlled sections only.
+  - "use `相关人员: @user1 @user2` or `协作请求:` bullet list for dispatch."
   - observer should include decision fields in YAML: analysis, should_trigger, reason, agent, comment.

src/issuelab/response_processor.py

@@ -20,6 +20,7 @@
     clean_mentions_in_text,
     filter_mentions,
 )
+from issuelab.utils.mentions import extract_controlled_mentions
 from issuelab.utils.yaml_text import extract_yaml_block
 
 logger = logging.getLogger(__name__)
@@ -56,8 +57,7 @@
         "mentions_max_count": 5,
     },
     "rules": {
-        "mentions_only_in_actions": True,
-        "yaml_required": True,
+        # Reserved for future rule flags.
     },
 }
 
@@ -456,7 +456,7 @@ def trigger_mentioned_agents(
     Returns:
         (results, allowed_mentions, filtered_mentions)
     """
-    mentions = extract_mentions_from_yaml(response)
+    mentions = extract_controlled_mentions(response)
 
     if not mentions:
         logger.info("[INFO] Response中没有@mentions")
@@ -554,7 +554,7 @@ def process_agent_response(
     response_text = normalized_response
 
     # 提取所有 @mentions（基于原始回复，避免规范化后丢失）
-    mentions = extract_mentions_from_yaml(raw_response_text)
+    mentions = extract_controlled_mentions(raw_response_text)
 
     # 清理主体内容（将所有 @username 替换为 "用户 username"）
     clean_response = clean_mentions_in_text(response_text)

tests/test_github.py

@@ -138,7 +138,7 @@ def fake_filter_mentions(mentions, policy=None, issue_number=None):
     monkeypatch.setattr("issuelab.tools.github.os.unlink", lambda _path: None)
     monkeypatch.setattr("issuelab.mention_policy.filter_mentions", fake_filter_mentions)
     monkeypatch.setattr(
-        "issuelab.response_processor.extract_mentions_from_yaml",
+        "issuelab.utils.mentions.extract_controlled_mentions",
         lambda _body: (_ for _ in ()).throw(AssertionError("should not parse body mentions")),
     )
 
@@ -156,8 +156,7 @@ def fake_run(cmd, capture_output, text, env):
 
     monkeypatch.setattr("issuelab.tools.github.subprocess.run", fake_run)
     monkeypatch.setattr("issuelab.tools.github.os.unlink", lambda _path: None)
-    monkeypatch.setattr("issuelab.response_processor.extract_mentions_from_yaml", lambda _body: [])
-    monkeypatch.setattr("issuelab.utils.mentions.extract_github_mentions", lambda _body: ["alice"])
+    monkeypatch.setattr("issuelab.utils.mentions.extract_controlled_mentions", lambda _body: [])
     monkeypatch.setattr(
         "issuelab.mention_policy.filter_mentions", lambda mentions, policy=None, issue_number=None: (mentions, [])
     )

tests/test_response_processor.py

@@ -83,14 +83,14 @@ def test_trigger_single_mentioned_agent(self, mock_trigger):
 
         mock_trigger.return_value = True
 
-        response = """```yaml
-summary: "Test"
-findings: []
-recommendations: []
-mentions:
-  - moderator
-confidence: "high"
-```"""
+        response = """[Agent: moderator]
+
+## Summary
+Test
+
+---
+相关人员: @moderator
+"""
         results, allowed, filtered = trigger_mentioned_agents(response, 1, "Title", "Body")
 
         assert results == {"moderator": True}
@@ -107,15 +107,14 @@ def test_trigger_multiple_mentioned_agents(self, mock_trigger):
 
         mock_trigger.return_value = True
 
-        response = """```yaml
-summary: "Test"
-findings: []
-recommendations: []
-mentions:
-  - reviewer_a
-  - reviewer_b
-confidence: "high"
-```"""
+        response = """[Agent: moderator]
+
+## Summary
+Test
+
+---
+相关人员: @reviewer_a @reviewer_b
+"""
         results, allowed, filtered = trigger_mentioned_agents(response, 2, "Title", "Body")
 
         assert results == {"reviewer_a": True, "reviewer_b": True}
@@ -128,15 +127,14 @@ def test_skip_system_accounts(self, mock_trigger):
         """跳过系统账号"""
         from issuelab.response_processor import trigger_mentioned_agents
 
-        response = """```yaml
-summary: "Test"
-findings: []
-recommendations: []
-mentions:
-  - github
-  - github-actions
-confidence: "high"
-```"""
+        response = """[Agent: moderator]
+
+## Summary
+Test
+
+---
+相关人员: @github @github-actions
+"""
         results, allowed, filtered = trigger_mentioned_agents(response, 1, "Title", "Body")
 
         assert results == {}
@@ -151,15 +149,14 @@ def test_trigger_with_system_and_real_users(self, mock_trigger):
 
         mock_trigger.return_value = True
 
-        response = """```yaml
-summary: "Test"
-findings: []
-recommendations: []
-mentions:
-  - github-actions
-  - reviewer_a
-confidence: "high"
-```"""
+        response = """[Agent: moderator]
+
+## Summary
+Test
+
+---
+相关人员: @github-actions @reviewer_a
+"""
         results, allowed, filtered = trigger_mentioned_agents(response, 1, "Title", "Body")
 
         assert results == {"reviewer_a": True}
@@ -187,14 +184,14 @@ def test_handle_trigger_failure(self, mock_trigger):
 
         mock_trigger.return_value = False
 
-        response = """```yaml
-summary: "Test"
-findings: []
-recommendations: []
-mentions:
-  - reviewer_a
-confidence: "high"
-```"""
+        response = """[Agent: moderator]
+
+## Summary
+Test
+
+---
+相关人员: @reviewer_a
+"""
         results, allowed, filtered = trigger_mentioned_agents(response, 1, "Title", "Body")
 
         assert results == {"reviewer_a": False}
@@ -218,10 +215,12 @@ def test_process_string_response(self, mock_trigger):
 summary: "Test"
 findings: []
 recommendations: []
-mentions:
-  - reviewer_a
 confidence: "high"
-```""",
+```
+
+---
+相关人员: @reviewer_a
+""",
             issue_number=1,
             issue_title="Title",
             issue_body="Body",
@@ -246,10 +245,12 @@ def test_process_dict_response(self, mock_trigger):
 summary: "Test"
 findings: []
 recommendations: []
-mentions:
-  - reviewer_b
 confidence: "high"
-```""",
+```
+
+---
+相关人员: @reviewer_b
+""",
                 "cost_usd": 0.01,
             },
             issue_number=1,
@@ -270,10 +271,12 @@ def test_auto_dispatch_disabled(self, mock_trigger):
 summary: "Test"
 findings: []
 recommendations: []
-mentions:
-  - reviewer_a
 confidence: "high"
-```""",
+```
+
+---
+相关人员: @reviewer_a
+""",
             issue_number=1,
             auto_dispatch=False,
         )