feat: require output templates for all system agents

gqy20 · gqy20 · commit bf9d6e8cbb41 · 2026-02-10T21:55:02.000+08:00
diff --git a/agents/arxiv_observer/agent.yml b/agents/arxiv_observer/agent.yml
@@ -12,6 +12,7 @@ enable_skills: false
 enable_subagents: false
 enable_mcp: false
 enable_system_mcp: false
+output_template: paper_observer_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/agents/moderator/agent.yml b/agents/moderator/agent.yml
@@ -14,6 +14,7 @@ enable_mcp: false
 enable_system_mcp: false
 output_format: markdown
 mentions_mode: controlled
+output_template: review_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/agents/observer/agent.yml b/agents/observer/agent.yml
@@ -12,6 +12,7 @@ enable_skills: false
 enable_subagents: false
 enable_mcp: false
 enable_system_mcp: false
+output_template: observer_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/agents/ops_daily/agent.yml b/agents/ops_daily/agent.yml
@@ -21,6 +21,7 @@ timeout_seconds: 240
 enable_skills: false
 enable_subagents: false
 enable_mcp: false
+output_template: concise_review_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/agents/pubmed_observer/agent.yml b/agents/pubmed_observer/agent.yml
@@ -12,6 +12,7 @@ enable_skills: false
 enable_subagents: false
 enable_mcp: false
 enable_system_mcp: false
+output_template: paper_observer_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/agents/reviewer_a/agent.yml b/agents/reviewer_a/agent.yml
@@ -12,6 +12,7 @@ enable_skills: false
 enable_subagents: false
 enable_mcp: false
 enable_system_mcp: false
+output_template: review_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/agents/reviewer_b/agent.yml b/agents/reviewer_b/agent.yml
@@ -12,6 +12,7 @@ enable_skills: false
 enable_subagents: false
 enable_mcp: false
 enable_system_mcp: false
+output_template: review_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/agents/summarizer/agent.yml b/agents/summarizer/agent.yml
@@ -12,6 +12,7 @@ enable_skills: false
 enable_subagents: false
 enable_mcp: false
 enable_system_mcp: false
+output_template: concise_review_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/agents/video_manim/agent.yml b/agents/video_manim/agent.yml
@@ -12,6 +12,7 @@ enable_skills: true
 enable_subagents: true
 enable_mcp: true
 enable_system_mcp: false
+output_template: review_v1
 
 repository: "gqy20/IssueLab"
 branch: "main"
diff --git a/config/output_templates.yml b/config/output_templates.yml
@@ -41,3 +41,51 @@ templates:
       sources:
         title: "## Sources"
         guidance: "列出关键来源 URL。"
+
+  observer_v1:
+    section_order:
+      - summary
+      - current_state
+      - decision
+      - rationale
+      - next_actions
+    sections:
+      summary:
+        title: "## Summary"
+        guidance: "用 1-2 句概括 issue 当前进展和关键问题。"
+      current_state:
+        title: "## Current State"
+        guidance: "列出当前状态、已完成事项和缺失信息。"
+      decision:
+        title: "## Decision"
+        guidance: "明确是否触发下游 agent，并说明目标。"
+      rationale:
+        title: "## Rationale"
+        guidance: "说明触发/不触发的依据与不确定性。"
+      next_actions:
+        title: "## Next Actions"
+        guidance: "给出 1-3 条后续动作。"
+
+  paper_observer_v1:
+    section_order:
+      - summary
+      - selection_basis
+      - recommended_items
+      - limitations
+      - sources
+    sections:
+      summary:
+        title: "## Summary"
+        guidance: "概述筛选范围与推荐结论。"
+      selection_basis:
+        title: "## Selection Basis"
+        guidance: "说明筛选标准和入选理由。"
+      recommended_items:
+        title: "## Recommended Items"
+        guidance: "逐条列出推荐条目与原因。"
+      limitations:
+        title: "## Limitations"
+        guidance: "说明证据边界、潜在偏差和缺失。"
+      sources:
+        title: "## Sources"
+        guidance: "给出可追溯链接。"
diff --git a/tests/test_agents.py b/tests/test_agents.py
@@ -1,5 +1,9 @@
 """测试代理模块"""
 
+from pathlib import Path
+
+import yaml
+
 from issuelab.agents import (
     discover_agents,
     get_available_agents,
@@ -144,3 +148,29 @@ def test_system_prompt_loaded_from_agents_dir(tmp_path, monkeypatch):
     assert "moderator" in agents
     assert "from agents" in agents["moderator"]["prompt"]
     assert agents["moderator"]["description"] == "from-agent-yml"
+
+
+def test_system_agents_have_output_template():
+    """所有 system agent 必须配置 output_template，且模板必须可解析。"""
+    templates_file = Path("config/output_templates.yml")
+    templates_doc = yaml.safe_load(templates_file.read_text(encoding="utf-8")) or {}
+    global_templates = templates_doc.get("templates", {}) if isinstance(templates_doc, dict) else {}
+
+    for agent_yml in Path("agents").glob("*/agent.yml"):
+        config = yaml.safe_load(agent_yml.read_text(encoding="utf-8")) or {}
+        if config.get("agent_type") != "system":
+            continue
+
+        output_template = config.get("output_template")
+        assert isinstance(output_template, str) and output_template.strip(), f"{agent_yml} missing output_template"
+
+        if output_template.startswith("local:"):
+            local_name = output_template.split(":", 1)[1].strip()
+            local_file = agent_yml.parent / "output_config.yml"
+            local_doc = yaml.safe_load(local_file.read_text(encoding="utf-8")) if local_file.exists() else {}
+            local_templates = local_doc.get("templates", {}) if isinstance(local_doc, dict) else {}
+            assert local_name in local_templates, f"{agent_yml} references missing local template {local_name}"
+        else:
+            assert (
+                output_template in global_templates
+            ), f"{agent_yml} references missing global template {output_template}"
