Raise error if desired select element has no aria-control#5303
Merged
Conversation
Extend `getSelectItemElementsForSelect` to raise an error if the desired select element has not `aria-control` attribute. Otherwise wrong item elements are returned.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Allow to associate a FormGroup title with a form element. This allows to use the byLabelText query helpers in the tests and also makes the forms more accessible.
Connect the PermissionDialog form group labels with their corresponding input elements. This allows to get the correct element in the tests using the byLabelTest query helper.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5303 +/- ##
==========================================
- Coverage 79.03% 79.03% -0.01%
==========================================
Files 1218 1218
Lines 32129 32131 +2
Branches 9599 9600 +1
==========================================
+ Hits 25394 25395 +1
- Misses 6028 6029 +1
Partials 707 707 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daniele-mng
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raise error if desired select element has no aria-control
Why
Extend
getSelectItemElementsForSelectto raise an error if the desired select element has notaria-controlattribute. Otherwise wrong item elements are returned.