Add a addPrefix function as an alternative to the withPrefix HOC#5307
Open
bjoernricks wants to merge 1 commit into
Open
Add a addPrefix function as an alternative to the withPrefix HOC#5307bjoernricks wants to merge 1 commit into
addPrefix function as an alternative to the withPrefix HOC#5307bjoernricks wants to merge 1 commit into
Conversation
For function components it is better to use a dedicated function then to a HOC. The withPrefix HOC is used in the alert dialog for setting the names of the input fields.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5307 +/- ##
=======================================
Coverage 79.06% 79.06%
=======================================
Files 1220 1221 +1
Lines 32180 32183 +3
Branches 9618 9579 -39
=======================================
+ Hits 25443 25446 +3
Misses 6030 6030
Partials 707 707 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a
addPrefixfunction as an alternative to the withPrefix HOCWhy
For function components it is better to use a dedicated function then to a HOC. The withPrefix HOC is used in the alert dialog for setting the names of the input fields.
Checklist