From c295ded64c1cbe48466d98a87e78df156a40763e Mon Sep 17 00:00:00 2001 From: Badi Ifaoui Date: Fri, 4 Sep 2026 09:57:04 +0000 Subject: [PATCH] Drop the Dart binding's unused serde_json dependency MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The 2.13.0 codegen sync added serde_json to bindings/dart/rust/Cargo.toml on the assumption the generated SSE codec referenced it directly, but the committed frb_generated.rs never does — the qualified-path fix for the Value/serde_json::Value name collision made the dependency unnecessary before the commit landed. Confirmed by a clean regen: dropping it produces zero diff in the generated glue, and cargo build/clippy/fmt and dart analyze/test all stay green. --- bindings/dart/rust/Cargo.lock | 55 ----------------------------------- bindings/dart/rust/Cargo.toml | 5 ---- 2 files changed, 60 deletions(-) diff --git a/bindings/dart/rust/Cargo.lock b/bindings/dart/rust/Cargo.lock index db04c11..8a0fc8b 100644 --- a/bindings/dart/rust/Cargo.lock +++ b/bindings/dart/rust/Cargo.lock @@ -37,7 +37,6 @@ version = "0.1.0" dependencies = [ "ae-core", "flutter_rust_bridge", - "serde_json", ] [[package]] @@ -571,12 +570,6 @@ dependencies = [ "typenum", ] -[[package]] -name = "itoa" -version = "1.0.18" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "8f42a60cbdf9a97f5d2305f08a87dc4e09308d1276d28c869c684d7777685682" - [[package]] name = "js-sys" version = "0.3.104" @@ -833,48 +826,6 @@ version = "1.0.28" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "8a7852d02fc848982e0c167ef163aaff9cd91dc640ba85e263cb1ce46fae51cd" -[[package]] -name = "serde" -version = "1.0.229" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "4148590afebada386688f18773da617792bf2ef03ffc1e4cbd2b1d45b023e0ba" -dependencies = [ - "serde_core", -] - -[[package]] -name = "serde_core" -version = "1.0.229" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "67dca2c9c51e58a4791a4b1ed58308b39c64224d349a935ab5039aa360942a48" -dependencies = [ - "serde_derive", -] - -[[package]] -name = "serde_derive" -version = "1.0.229" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "e7a5d71263a5a7d47b41f6b3f06ba276f10cc18b0931f1799f710578e2309348" -dependencies = [ - "proc-macro2", - "quote", - "syn 3.0.3", -] - -[[package]] -name = "serde_json" -version = "1.0.151" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c841b55ecdae098c80dcae9cf767f6f8a0c2cdb3416bbef72181df4d0fe73f14" -dependencies = [ - "itoa", - "memchr", - "serde", - "serde_core", - "zmij", -] - [[package]] name = "sha2" version = "0.11.0" @@ -1094,9 +1045,3 @@ name = "zeroize" version = "1.9.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "e13c156562582aa81c60cb29407084cdb54c4164760106ab78e6c5b0858cf64e" - -[[package]] -name = "zmij" -version = "1.0.23" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "29666d0abbfad1e3dc4dcf6144730dd3a3ab225bbbdac83319345b1b44ccfc1b" diff --git a/bindings/dart/rust/Cargo.toml b/bindings/dart/rust/Cargo.toml index 9975a59..b3611a0 100644 --- a/bindings/dart/rust/Cargo.toml +++ b/bindings/dart/rust/Cargo.toml @@ -16,11 +16,6 @@ crate-type = ["cdylib", "staticlib"] [dependencies] ae-core = { path = "../../../crates/ae-core" } flutter_rust_bridge = "=2.13.0" -# Referenced directly by the flutter_rust_bridge-generated SSE codec in -# frb_generated.rs (serde_json::Value), not re-exported through -# flutter_rust_bridge itself — version matches what that crate's own -# `[dependencies.serde_json]` declares. -serde_json = "1.0" [profile.release] lto = true