bug: post-code.sh swallows gh pr create error output via 2>&1 redirect

[guyoron1]

Summary

When gh pr create fails in post-code.sh, the error message is not visible in the workflow logs because stderr is redirected into the PR_URL variable via 2>&1.

Details

The current implementation captures both stdout and stderr into the PR_URL variable:

PR_URL="$(gh pr create \
  --repo "${REPO_FULL_NAME}" \
  --head "${BRANCH}" \
  --base "${TARGET_BRANCH}" \
  --title "${PR_TITLE}" \
  --body "${PR_BODY}" \
  2>&1)"
echo "PR created: ${PR_URL}"

When gh pr create fails, the error message (e.g. 403 Forbidden, 422 Validation Failed) is stored in PR_URL instead of being printed to the logs.

Suggested Fix

Use the if ! pattern already used in reconcile-repos.sh:

if ! PR_URL=$(gh pr create \
  --repo "${REPO_FULL_NAME}" \
  --head "${BRANCH}" \
  --base "${TARGET_BRANCH}" \
  --title "${PR_TITLE}" \
  --body "${PR_BODY}"); then
  echo "::error::Failed to create PR: see above for details"
  exit 1
fi

---

Mirrored from fullsend-ai#2348

[guyoron1]

/fs-triage

[guyoron1]

/fs-code

[fullsend-ai-coder]

🤖 Finished Code · ✅ Success · Started 9:31 PM UTC · Completed 9:35 PM UTC
Commit: bb5c185 · View workflow run →