Skip to content
This repository was archived by the owner on Jul 4, 2023. It is now read-only.
This repository was archived by the owner on Jul 4, 2023. It is now read-only.

Rectangular apertures in outline break render #10

@CapnKernel

Description

@CapnKernel

Every two weeks, I get a large order from someone who uses "Robot Room Copper Connection":

http://www.robotroom.com/CopperConnection/

Sometimes their zips don't render in gerblook. Through bisection I found the reason.

Here's an outline file that doesn't work:

G04 This is an RS-274x file exported by *
G04 gerbv version 2.6A *
G04 More information is available about gerbv at *
G04 http://gerbv.geda-project.org/ *
G04 --End of header info--*
%MOIN*%
%FSLAX34Y34*%
%IPPOS*%
G04 --Define apertures--*
%ADD10R,0.0060X0.0060*%
%ADD11R,0.0070X0.0070*%
G04 --Start main section--*
G54D10*
G01X0000000Y0050790D02*
G01X0080910Y0050790D01*
G01X0080910Y0000000D01*
G01X0000000Y0000000D01*
G01X0000000Y0050790D01*
M02*

And here's one that does:

G04 This is an RS-274x file exported by *
G04 gerbv version 2.6A *
G04 More information is available about gerbv at *
G04 http://gerbv.geda-project.org/ *
G04 --End of header info--*
%MOIN*%
%FSLAX34Y34*%
%IPPOS*%
G04 --Define apertures--*
%ADD10C,0.0060*%
%ADD11C,0.0070*%
G04 --Start main section--*
G54D10*
G01X0000000Y0050790D02*
G01X0080910Y0050790D01*
G01X0080910Y0000000D01*
G01X0000000Y0000000D01*
G01X0000000Y0050790D01*
M02*

The difference is in the aperture definitions:

diff -u ../old/nullA_CASE_PANEL_V5.gko nullA_CASE_PANEL_V5.gko
--- ../old/nullA_CASE_PANEL_V5.gko  2016-03-03 00:25:07.494756442 +1100
+++ nullA_CASE_PANEL_V5.gko 2016-03-03 01:07:45.613888540 +1100
@@ -7,8 +7,8 @@
 %FSLAX34Y34*%
 %IPPOS*%
 G04 --Define apertures--*
-%ADD10R,0.0060X0.0060*%
-%ADD11R,0.0070X0.0070*%
+%ADD10C,0.0060*%
+%ADD11C,0.0070*%
 G04 --Start main section--*
 G54D10*
 G01X0000000Y0050790D02*

My guess is that the version of gerbv that gerblook's using is too old to support "R"-type rectangular aperture definitions. ("C"-type circular definitions seem fine)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions