PyEval._invoke silently skips IndexError in certain pipeline

[haeter525]

This line in certain situations throws IndexError, which is silenced elsewhere (because analysis does not fail overall):

quark-engine/quark/evaluator/pyeval.py

Line 213 in 05e7ffa

valueOfRegList[argIdx].value_type = argTypes[argIdx]

This happens (at least, in my test case usage Telegram_12.0.0_APKPure.apk) on instruction "filled-new-array", where targetMethod is "new-array()".

instruction ['filled-new-array', 'v13', 'v11', 'v12', 'new-array()[I']
targetMethod new-array()[I
argIdxWithoutType [1, 2]
valueOfRegList [Primitive('0'), Primitive('1'), Primitive('2')]
argTypes ['new-array()[', '']
argIdx 2

new-array() does not have argument type aliases inside parentheses, so array argTypes is not filled.

quark-engine/quark/evaluator/pyeval.py

Lines 201 to 210 in 05e7ffa

	rawArgTypes = targetMethod[
	targetMethod.find("(") + 1 : targetMethod.find(")")
	].split(" ")
	for argType in rawArgTypes:
	argTypes.append(argType)
	if argType in ["J", "D"]:
	# Put long and double twice
	# because these types take up two registers.
	argTypes.append(argType)

However, new-array does specify argument type after bracket, i.e. new-array()[I indicates, that it's array of integers, so maybe arguments should be parsed from there?

[haeter525]

Other issues, that may be relevant to this issue:

1. Is it correct, that in the abovementioned case, the first argument type is method itself?
2. The last char of targetMethod is stripped, if it does not have "->", seems like a bug

   quark-engine/quark/evaluator/pyeval.py

   Line 198 in 05e7ffa

   else [targetMethod[: targetMethod.find("->")]]

3. If there is nothing inside parentheses, rawArgTypes is initialized as array with single empty string, maybe this is a bug?

   quark-engine/quark/evaluator/pyeval.py

   Lines 201 to 203 in 05e7ffa

   	rawArgTypes = targetMethod[
   	targetMethod.find("(") + 1 : targetMethod.find(")")
   	].split(" ")

[haeter525]

new-array()[I should specify argument types to avoid IndexError. In this case, it should be new-array(I I I)[I. This is definitely a bug.

Regarding the other issues:

1. No. That is actually a side effect of the above bug. argTypes should be an empty list after line 198, as Quark treats "filled-new-array" similarly to an "invoke-static" instruction in this function.
2. Yes. If targetMethod does not contain "->", argTypes should be initialized as an empty list to handle "filled-new-array" correctly.
3. Yes. In this scenario, rawArgTypes should be initialized as an empty array rather than containing an empty string.

Thank you for raising these points! I’ll find some time to implement the fixes, but if you’re interested in tackling them, feel free to submit a PR. I’d be happy to review it.