Extra tick in configuration fields

[aussieklutz]

Extra single quote character displays in either host or port fields

[aussieklutz]

In the autossh module

[aussieklutz]

Issue persists after full reflash

[sho-luv]

Yeah I'm seeing the same issue...

[sho-luv]

So this issue is a result of the Lan Turtle having the config file: "/etc/config/autossh"

cat /etc/config/autossh
config autossh
	option ssh	'-i /etc/dropbear/id_rsa -N -T -R 2222:localhost:22 user@host'
	option gatetime	'0'
	option monitorport	'20000'
	option poll	'600'

And this github autossh module not matching up with this version of autossh config file.
Seems like it would be easer to rearranging the line:

   '-i /etc/dropbear/id_rsa -N -T -R 2222:localhost:22 user@host' 

to

   '-i /etc/dropbear/id_rsa -R 2222:localhost:22 user@host -N -T'

That would prevent the interaction with the single quote character. However since I'm not sure how easy it is to change the default autossh config file. We can do some ugly mods to the autossh module. Just add sed to delete the trailing '

[MathieuBujold]

I have an issue. In the turtle menu, in the autossh. When I click on connect, everything work. The autossh is enable but it's not booting on start like it suppose to do. Any tips on how to fix this.

[bad-antics]

The extra single quote in the autossh configuration fields is caused by the module's shell script not properly stripping quotes when reading from /etc/config/autossh.

Root cause:

The autossh config file stores the SSH options in a single-quoted string:

option ssh '-i /etc/dropbear/id_rsa -N -T -R 2222:localhost:22 user@host'

The module's configure function reads this with uci get autossh.@autossh[0].ssh which returns the value with the quotes included, then the dialog menu parses it incorrectly.

Fix:

As @sho-luv pointed out, the fix is to handle the quoting properly. In the module script:

# Instead of:
HOST=$(uci get autossh.@autossh[0].ssh | awk '{print $NF}')

# Use sed to strip the trailing quote:
HOST=$(uci get autossh.@autossh[0].ssh | awk '{print $NF}' | sed "s/'//g")

# Or better, rearrange the ssh options string so the quoted flags
# come AFTER the user@host:
# '-i /etc/dropbear/id_rsa -R 2222:localhost:22 user@host -N -T'

Alternative fix — rewrite the config parsing:

# Read the full SSH string, strip all quotes, then parse
SSH_STRING=$(uci get autossh.@autossh[0].ssh | tr -d "'")
HOST=$(echo "$SSH_STRING" | grep -oP '\S+@\S+')
PORT=$(echo "$SSH_STRING" | grep -oP '(?<=-R )\d+')

For the auto-start issue mentioned in comments:

The autossh not connecting on boot is a separate issue — add a network-wait loop:

# In /etc/init.d/autossh start()
while ! ping -c 1 -W 2 8.8.8.8 >/dev/null 2>&1; do sleep 5; done

This is a long-standing bug that affects all LAN Turtle firmware versions. A PR fixing the quote handling would be welcome.