From 72b28b0960d51ef62e7c05f86b6bf51424179e5b Mon Sep 17 00:00:00 2001 From: Matti Airas Date: Wed, 1 Jul 2026 21:15:05 +0300 Subject: [PATCH] fix(settings): trim the browser tab title before storing Re-lands the trim fix from the content review of #63 (configurable tab title): #63 merged at its pre-fix head, so this follow-up delivers it. The setter persisted the raw value; only the resolver trimmed for display, so a padded/whitespace-only tab title was stored verbatim. Trim on store and normalize blank to '' (the resolver still falls back to the default). Co-Authored-By: Claude Opus 4.8 (1M context) Claude-Session: https://claude.ai/code/session_01ETfeXXs8R5ciw6nGxGYj2C --- src/app/core/services/settings.service.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/app/core/services/settings.service.ts b/src/app/core/services/settings.service.ts index 3fec2596..0d67e96b 100644 --- a/src/app/core/services/settings.service.ts +++ b/src/app/core/services/settings.service.ts @@ -474,7 +474,9 @@ export class SettingsService { } public setBrowserTabTitle(title: string) { - this.browserTabTitle.next(title); + // Trim before storing so a padded/whitespace-only value isn't persisted (the resolver already + // trims for display; this keeps the saved config clean and blank values normalized to ''). + this.browserTabTitle.next((title ?? '').trim()); const appConf = this.buildAppStorageObject(); if (this.useSharedConfig) {