support Azure AD App roles#137
Open
nbutton23 wants to merge 4 commits into
Open
Conversation
nbutton23
commented
Mar 14, 2023
| }{ | ||
| DisplayName: to.StringPtr(displayName), | ||
| DisplayName: to.StringPtr(displayName), | ||
| SignInAudience: to.StringPtr("AzureADMyOrg"), |
Contributor
Author
There was a problem hiding this comment.
This is needed to fix an issue with persist_app since the default value will only allow 2 active tokens at a time.
If needed I can pull this into its own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Support assigning Azure AD App Roles to the created Service Principal. This can be used to grant Service Principals access to the Azure Graph API. GraphAPI is the only supported way to perform actions in AAD
Design of Change
Adds a new field
app_rolesthat accepts an array of apps and the roles to be assigned. Using the Graph API appRoleAssignment the roles are added.Roles are expected to be provided as a JSON formatted string in the format
I have been running a version of this plugin on our vault instance for a few months with no issues.
Related Issues/Pull Requests
[ ] Issue #92
Contributor Checklist
[x] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
[x] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible