Fix exit code from 'Aborting on container exit...' on down

Author: hasnat

.github/workflows/main.yml

@@ -13,15 +13,13 @@ jobs:
 
     steps:
       - name: Checkout 
-        uses: actions/checkout@v2 # Required to mount the Github Workspace to a volume
+        uses: actions/checkout@v2
       - name: run one version test
         uses: sudo-bot/action-docker-compose@latest
         with:
-          # https://docs.docker.com/compose/reference/overview/
           cli-args: -f ./regression-run/docker-compose.yml up --build s3fs-tests --exit-code-from s3fs-tests
       - name: run multiversion test
         uses: sudo-bot/action-docker-compose@latest
         with:
-          # https://docs.docker.com/compose/reference/overview/
           cli-args: -f ./regression-run/docker-compose.yml up --build s3fs-test-multiple-versions --exit-code-from s3fs-test-multiple-versions
 

regression-run/docker-compose.yml

@@ -32,7 +32,7 @@ services:
       AWS_SECRET_KEY: 'secret-key-dont-matter-for-fake-s3'
       AWS_ENDPOINT: 'http://s3fs-fake-s3:4566/'
     # defaulting command to unit tests, for multiversion we will use slimmer regression.js
-    command: ${TEST_COMMAND:-npm run test}
+    command: "${TEST_COMMAND:-npm run test}"
 
 
   s3fs-test-multiple-versions:

regression-run/test-multiple-versions/Dockerfile

@@ -1,9 +1,9 @@
 FROM alpine:3.16
 
 WORKDIR /usr/local/src/s3fs
-COPY . .
 COPY --from=docker /usr/libexec/docker/cli-plugins/docker-compose /usr/bin/docker-compose
 COPY ./regression-run/test-multiple-versions/entrypoint.sh /entrypoint.sh
+COPY . .
 
 ENTRYPOINT /entrypoint.sh
 

regression-run/test-multiple-versions/entrypoint.sh

@@ -5,30 +5,30 @@ function cleanup()
 {
     exit_status=$?
     echo "exit was $exit_status"
-    docker-compose -f regression-run/docker-compose.yml down 2>&1|| true
-    exit $exit_status
+
+    docker-compose -f regression-run/docker-compose.yml rm s3fs-fake-s3 -f  || true
+
+    exit "$exit_status"
 }
 trap cleanup EXIT
 
-docker-compose -f regression-run/docker-compose.yml up -d --no-recreate s3fs-fake-s3
+docker-compose -f regression-run/docker-compose.yml up --build -d --no-recreate s3fs-fake-s3
 
 for NODEJS_VERSION in $NODEJS_VERSIONS_TO_TEST_UNIT
 do
-    export NODEJS_VERSION="${NODEJS_VERSION}"
-    docker-compose -f regression-run/docker-compose.yml build s3fs-tests
     echo "======================Start unit testing nodejs version ${NODEJS_VERSION}============================="
-    NODE_ENV=production \
+    NODEJS_VERSION="${NODEJS_VERSION}" \
+    NODE_ENV=development \
     TEST_COMMAND="npm run test" \
-    docker-compose -f regression-run/docker-compose.yml up s3fs-tests --no-recreate --exit-code-from s3fs-tests
+    docker-compose -f regression-run/docker-compose.yml up --build s3fs-tests --no-recreate --exit-code-from s3fs-tests
 done
 
 
 for NODEJS_VERSION in $NODEJS_VERSIONS_TO_TEST_REGRESSION
 do
-    export NODEJS_VERSION="${NODEJS_VERSION}"
-    docker-compose -f regression-run/docker-compose.yml build s3fs-tests
     echo "======================Start regression testing nodejs version ${NODEJS_VERSION}============================="
+    NODEJS_VERSION="${NODEJS_VERSION}" \
     NODE_ENV=production \
     TEST_COMMAND="npm run test-regression" \
-    docker-compose -f regression-run/docker-compose.yml up s3fs-tests --no-recreate --exit-code-from s3fs-tests
+    docker-compose -f regression-run/docker-compose.yml up --build s3fs-tests --no-recreate --exit-code-from s3fs-tests
 done