Add integration tests for storage tester console command#1
Closed
amit-warbhe wants to merge 0 commit into
Closed
Conversation
hbragge-acn
requested changes
Jul 1, 2025
Owner
hbragge-acn
left a comment
hbragge-acn
left a comment
There was a problem hiding this comment.
This is a good start, I've added some comments
|
|
||
| [target_process] | ||
| command_line = "../../cmake-build-posix/application/app.referenceApp.elf < /tmp/pty_forwarder > /tmp/pty_forwarder" | ||
| command_line = "../../cmake-build-posix-gcc/application/app.referenceApp.elf < /tmp/pty_forwarder > /tmp/pty_forwarder" |
Owner
There was a problem hiding this comment.
Is this change intended? The documentation doesn't seem to use "-gcc" suffix for the cmake directories.
Author
There was a problem hiding this comment.
After considering clang along with gcc, now we need to mention the compiler in the latest build command, so the elf path changes accordingly.
amit-warbhe
force-pushed
the
storage
branch
2 times, most recently
from
a4312ca to
48aa9d9
Compare
hbragge-acn
force-pushed
the
storage
branch
3 times, most recently
from
a3fb23b to
4127dce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.