From 1d319079ed5d79e3aea3384a5a585c8a3711b6ba Mon Sep 17 00:00:00 2001 From: hikariming Date: Wed, 29 Jul 2026 15:53:26 +0800 Subject: [PATCH] chore(codeowners): own main with all three core maintainers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Only @hikariming was a code owner, so with "Require review from Code Owners" on main every PR — including ones from the other two maintainers reviewing each other — stalled waiting on a single person. List all three maintainers instead. GitHub never counts a PR author's own approval, so the one required approval always has to come from one of the other two, which is the cross-review we actually want. Co-Authored-By: Claude Opus 5 (1M context) --- .github/CODEOWNERS | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 6f9c0d5a..6ce50f22 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,11 +1,14 @@ -# Code owners for github-roast. +# Code owners for ghfind. # -# Every pull request targeting a protected branch (main) requires review from -# the owner(s) listed here, because the branch ruleset enables -# "Require review from Code Owners". This enforces "only I decide what lands on -# main" while collaborators work on feature branches + PRs. +# Every pull request targeting a protected branch (main) requires an approval +# from one of the owners listed here, because the branch ruleset enables +# "Require review from Code Owners" with 1 required approval. +# +# GitHub never counts a pull request author's own approval, so listing all +# three core maintainers means every PR has to be cross-reviewed by one of the +# other two: whoever opens it cannot be the one who unblocks it. # # Syntax: <@owner ...> (last matching line wins) -# Default: the whole repository is owned by @hikariming. -* @hikariming +# Default: the whole repository is owned by the three core maintainers. +* @hikariming @KurosawaGeeker @AsperforMias