From 110abb879f23d8542242367b6fbc5ebf4110728f Mon Sep 17 00:00:00 2001 From: RiteshHMCTS Date: Fri, 29 May 2026 14:14:42 +0100 Subject: [PATCH 1/3] unused @types/jasminewd2 removed --- e2e/tsconfig.e2e.json | 3 +-- package.json | 1 - yarn.lock | 17 ----------------- 3 files changed, 1 insertion(+), 20 deletions(-) diff --git a/e2e/tsconfig.e2e.json b/e2e/tsconfig.e2e.json index 67d7e6a2e9..ba6bd29615 100644 --- a/e2e/tsconfig.e2e.json +++ b/e2e/tsconfig.e2e.json @@ -6,8 +6,7 @@ "target": "es5", "types": [ "jasmine", - "jasminewd2", "node" ] } -} \ No newline at end of file +} diff --git a/package.json b/package.json index 7cdcbde8c5..6f83448165 100644 --- a/package.json +++ b/package.json @@ -105,7 +105,6 @@ "@storybook/preset-scss": "^1.0.3", "@storybook/testing-library": "^0.2.0", "@types/jasmine": "~2.8.0", - "@types/jasminewd2": "^2.0.3", "@types/node": "^20.19.0", "@types/pegjs": "^0.10.0", "@types/underscore": "^1.11.4", diff --git a/yarn.lock b/yarn.lock index dcefd6d975..b7b8b6e44c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3426,7 +3426,6 @@ __metadata: "@storybook/preset-scss": "npm:^1.0.3" "@storybook/testing-library": "npm:^0.2.0" "@types/jasmine": "npm:~2.8.0" - "@types/jasminewd2": "npm:^2.0.3" "@types/node": "npm:^20.19.0" "@types/pegjs": "npm:^0.10.0" "@types/underscore": "npm:^1.11.4" @@ -8036,13 +8035,6 @@ __metadata: languageName: node linkType: hard -"@types/jasmine@npm:*": - version: 5.1.13 - resolution: "@types/jasmine@npm:5.1.13" - checksum: 10/f873c5650202b339866244a1c019fecc7abe47694cf8899ef17e965aae51b57cd777bb7ab813a61c4482cbc436eb0c18f02ff8def320999e403a56bd5a80d21e - languageName: node - linkType: hard - "@types/jasmine@npm:~2.8.0": version: 2.8.23 resolution: "@types/jasmine@npm:2.8.23" @@ -8050,15 +8042,6 @@ __metadata: languageName: node linkType: hard -"@types/jasminewd2@npm:^2.0.3": - version: 2.0.13 - resolution: "@types/jasminewd2@npm:2.0.13" - dependencies: - "@types/jasmine": "npm:*" - checksum: 10/a661e1add2d7c0582b05e79fcdbc0297fa4292b38b1273e2970d88d0775c85ecc322e1417c84826b5e6caeceab4dc267f5f00300c0c11d0fc459601057698700 - languageName: node - linkType: hard - "@types/jsdom@npm:^20.0.0": version: 20.0.1 resolution: "@types/jsdom@npm:20.0.1" From e4ce44870f57c86f76bf4823bfcd160357c407bd Mon Sep 17 00:00:00 2001 From: RiteshHMCTS Date: Mon, 1 Jun 2026 11:46:25 +0100 Subject: [PATCH 2/3] upgrade jasmine library --- package.json | 4 +-- projects/ccd-case-ui-toolkit/package.json | 2 +- .../src/jasmine-compat.d.ts | 28 +++++++++++++++++++ .../query-write-date-input.component.spec.ts | 4 --- .../shared/services/http/http.service.spec.ts | 10 +++---- yarn.lock | 10 +++---- 6 files changed, 41 insertions(+), 17 deletions(-) create mode 100644 projects/ccd-case-ui-toolkit/src/jasmine-compat.d.ts diff --git a/package.json b/package.json index 6f83448165..445b429c96 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@hmcts/ccd-case-ui-toolkit", - "version": "7.3.53", + "version": "7.3.54-exui-1855-rc-1", "engines": { "node": ">=20.19.0" }, @@ -104,7 +104,7 @@ "@storybook/manager-webpack4": "^6.5.10", "@storybook/preset-scss": "^1.0.3", "@storybook/testing-library": "^0.2.0", - "@types/jasmine": "~2.8.0", + "@types/jasmine": "^6.0.0", "@types/node": "^20.19.0", "@types/pegjs": "^0.10.0", "@types/underscore": "^1.11.4", diff --git a/projects/ccd-case-ui-toolkit/package.json b/projects/ccd-case-ui-toolkit/package.json index 366713c27f..c64a26e80d 100644 --- a/projects/ccd-case-ui-toolkit/package.json +++ b/projects/ccd-case-ui-toolkit/package.json @@ -1,6 +1,6 @@ { "name": "@hmcts/ccd-case-ui-toolkit", - "version": "7.3.53", + "version": "7.3.54-exui-1855-rc-1", "engines": { "node": ">=20.19.0" }, diff --git a/projects/ccd-case-ui-toolkit/src/jasmine-compat.d.ts b/projects/ccd-case-ui-toolkit/src/jasmine-compat.d.ts new file mode 100644 index 0000000000..191e2cf71d --- /dev/null +++ b/projects/ccd-case-ui-toolkit/src/jasmine-compat.d.ts @@ -0,0 +1,28 @@ +// Keeps the existing test suite compatible with newer, stricter Jasmine typings. +declare function spyOn(object: T, method: string): jasmine.Spy; + +declare namespace jasmine { + interface SpyAnd { + returnValue(val: any): Spy; + returnValues(...values: any[]): Spy; + callFake(fn: Func): Spy; + } + + interface FunctionMatchers { + toHaveBeenCalledWith(...params: any[]): void; + toHaveBeenCalledOnceWith(...params: any[]): void; + } + + interface Matchers { + toBe(expected: any, expectationFailOutput?: any): void; + toEqual(expected: any, expectationFailOutput?: any): void; + } + + interface Calls { + argsFor(index: number): any[]; + allArgs(): ReadonlyArray; + all(): ReadonlyArray>; + mostRecent(): CallInfo; + first(): CallInfo; + } +} diff --git a/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/query-management/components/query-write/query-write-date-input/query-write-date-input.component.spec.ts b/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/query-management/components/query-write/query-write-date-input/query-write-date-input.component.spec.ts index fc13a5fcff..5c2d615378 100644 --- a/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/query-management/components/query-write/query-write-date-input/query-write-date-input.component.spec.ts +++ b/projects/ccd-case-ui-toolkit/src/lib/shared/components/palette/query-management/components/query-write/query-write-date-input/query-write-date-input.component.spec.ts @@ -70,9 +70,7 @@ describe('QueryWriteDateInputComponent', () => { describe('updateDate', () => { it('should invoke onChange and onTouched when updateDate is called with a valid date input', () => { - // @ts-expect-error - private method const onChangeSpy = spyOn(component, 'onChange'); - // @ts-expect-error - private method const onTouchedSpy = spyOn(component, 'onTouched'); component.day = 7; component.month = 6; @@ -85,9 +83,7 @@ describe('QueryWriteDateInputComponent', () => { }); it('should invoke onChange with null when updateDate is called with an invalid date input', () => { - // @ts-expect-error - private method const onChangeSpy = spyOn(component, 'onChange'); - // @ts-expect-error - private method const onTouchedSpy = spyOn(component, 'onTouched'); component.day = 35; component.month = 15; diff --git a/projects/ccd-case-ui-toolkit/src/lib/shared/services/http/http.service.spec.ts b/projects/ccd-case-ui-toolkit/src/lib/shared/services/http/http.service.spec.ts index 2a8c3ea2de..8459884264 100644 --- a/projects/ccd-case-ui-toolkit/src/lib/shared/services/http/http.service.spec.ts +++ b/projects/ccd-case-ui-toolkit/src/lib/shared/services/http/http.service.spec.ts @@ -114,7 +114,7 @@ describe('HttpService', () => { httpService.get(URL, options); - const headers = httpMock.get.calls.mostRecent().args[1].headers; + const headers = httpMock.get.calls.mostRecent().args[1].headers as HttpHeaders; expect(headers.get('Content-Type')).toEqual(CONTENT_TYPE_HEADER_VALUE); expect(headers.get('Accept')).toEqual(ACCEPT_HEADER_VALUE); })); @@ -140,7 +140,7 @@ describe('HttpService', () => { httpService.get(URL, options); - const headers = httpMock.get.calls.mostRecent().args[1].headers; + const headers = httpMock.get.calls.mostRecent().args[1].headers as HttpHeaders; expect(headers.get('Content-Type')).toEqual('application/json'); expect(headers.get('Accept')).toEqual('application/json'); })); @@ -220,7 +220,7 @@ describe('HttpService', () => { httpService.post(URL, BODY, options); - const headers = httpMock.post.calls.mostRecent().args[2].headers; + const headers = httpMock.post.calls.mostRecent().args[2].headers as HttpHeaders; expect(headers.get('Content-Type')).toEqual('application/json'); expect(headers.get('Accept')).toEqual('application/json'); })); @@ -284,7 +284,7 @@ describe('HttpService', () => { httpService.put(URL, BODY, options); - const headers = httpMock.put.calls.mostRecent().args[2].headers; + const headers = httpMock.put.calls.mostRecent().args[2].headers as HttpHeaders; expect(headers.get('Content-Type')).toEqual('application/json'); expect(headers.get('Accept')).toEqual('application/json'); })); @@ -348,7 +348,7 @@ describe('HttpService', () => { httpService.delete(URL, options); - const headers = httpMock.delete.calls.mostRecent().args[1].headers; + const headers = httpMock.delete.calls.mostRecent().args[1].headers as HttpHeaders; expect(headers.get('Content-Type')).toEqual('application/json'); expect(headers.get('Accept')).toEqual('application/json'); })); diff --git a/yarn.lock b/yarn.lock index b7b8b6e44c..ec67c04cba 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3425,7 +3425,7 @@ __metadata: "@storybook/manager-webpack4": "npm:^6.5.10" "@storybook/preset-scss": "npm:^1.0.3" "@storybook/testing-library": "npm:^0.2.0" - "@types/jasmine": "npm:~2.8.0" + "@types/jasmine": "npm:^6.0.0" "@types/node": "npm:^20.19.0" "@types/pegjs": "npm:^0.10.0" "@types/underscore": "npm:^1.11.4" @@ -8035,10 +8035,10 @@ __metadata: languageName: node linkType: hard -"@types/jasmine@npm:~2.8.0": - version: 2.8.23 - resolution: "@types/jasmine@npm:2.8.23" - checksum: 10/01d2c2ed4d651147ebc6ff690a5795f6a33d007f5965cfb7f76bda104f9cc900ecebbd26046cf59a994a1e6ba32feafe5625777504e600616f99ffb2ec12f48c +"@types/jasmine@npm:^6.0.0": + version: 6.0.0 + resolution: "@types/jasmine@npm:6.0.0" + checksum: 10/22a838ab8d3221da78629819744b7a0065ce6381d198d745258c3ec29974470240160d47fb06b629c1653f285ed23c15c101f0f6939d2817abc02f253ff491b7 languageName: node linkType: hard From 99b98cd3408ab8150aecc7418da031448ad204ad Mon Sep 17 00:00:00 2001 From: RiteshHMCTS Date: Fri, 5 Jun 2026 14:19:31 +0100 Subject: [PATCH 3/3] jasmine upgrade --- package.json | 2 +- yarn.lock | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 445b429c96..f30eae5daf 100644 --- a/package.json +++ b/package.json @@ -104,7 +104,7 @@ "@storybook/manager-webpack4": "^6.5.10", "@storybook/preset-scss": "^1.0.3", "@storybook/testing-library": "^0.2.0", - "@types/jasmine": "^6.0.0", + "@types/jasmine": "~5.1.0", "@types/node": "^20.19.0", "@types/pegjs": "^0.10.0", "@types/underscore": "^1.11.4", diff --git a/yarn.lock b/yarn.lock index ec67c04cba..9987f522fa 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3425,7 +3425,7 @@ __metadata: "@storybook/manager-webpack4": "npm:^6.5.10" "@storybook/preset-scss": "npm:^1.0.3" "@storybook/testing-library": "npm:^0.2.0" - "@types/jasmine": "npm:^6.0.0" + "@types/jasmine": "npm:~5.1.0" "@types/node": "npm:^20.19.0" "@types/pegjs": "npm:^0.10.0" "@types/underscore": "npm:^1.11.4" @@ -8035,10 +8035,10 @@ __metadata: languageName: node linkType: hard -"@types/jasmine@npm:^6.0.0": - version: 6.0.0 - resolution: "@types/jasmine@npm:6.0.0" - checksum: 10/22a838ab8d3221da78629819744b7a0065ce6381d198d745258c3ec29974470240160d47fb06b629c1653f285ed23c15c101f0f6939d2817abc02f253ff491b7 +"@types/jasmine@npm:~5.1.0": + version: 5.1.15 + resolution: "@types/jasmine@npm:5.1.15" + checksum: 10/e86a962c153ff91ffe3c65a633578a5e3f6e065e58268c00e839b03dac6792b1e0a2afca216ccfa1e31647e49ef1a935332242350dca91a2940ad883643abd04 languageName: node linkType: hard