From 75fa5950d3482e98b3a5c7a29cd73377a58047cf Mon Sep 17 00:00:00 2001 From: bey0ne <195894611+bey0ne@users.noreply.github.com> Date: Tue, 27 Oct 2026 12:19:25 +0000 Subject: [PATCH] Targeted Payloads: tell users to add their tag first (#40) With no saved tag, the menu only shows "+ Scan NFC" and "+ Type Barcode", and several users looked there for the BMPs they had dropped. The header now reads "Add your tag first" and a hint row points to tag > Set Image. README step 4 says the same. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01QYkmJ3RnCgGZEBKnfRJt5x --- README.md | 2 +- scenes/tagtinker_scene_target_menu.c | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 76ea17d..1ba33e7 100644 --- a/README.md +++ b/README.md @@ -71,7 +71,7 @@ Only test tags you own or are allowed to test. 1. Build the Flipper app from this repository and install it via `ufbt`. The first launch creates `apps_data/tagtinker/dropped/` on your SD card. 2. Open **[i12bp8.github.io/TagTinker](https://i12bp8.github.io/TagTinker/)** in any browser, pick your tag profile, drop an image, tweak, and download the BMP. 3. Copy the BMP into `apps_data/tagtinker/dropped/` on the SD card (over `qFlipper`, USB MTP, or whatever you use). -4. On the Flipper open `Targeted Payloads → → Set Image`, pick the BMP, choose a page, send. +4. On the Flipper open `Targeted Payloads`. If your tag is not listed yet, add it first with `+ Scan NFC` or `+ Type Barcode`. Then open ` → Set Image`, pick the BMP, choose a page, send. ## Development diff --git a/scenes/tagtinker_scene_target_menu.c b/scenes/tagtinker_scene_target_menu.c index d3df7e5..bf901e7 100644 --- a/scenes/tagtinker_scene_target_menu.c +++ b/scenes/tagtinker_scene_target_menu.c @@ -7,6 +7,7 @@ enum { TargetMenuScanNfc = 99, TargetMenuAddNew = 100, + TargetMenuHint = 101, }; static void target_menu_cb(void* ctx, uint32_t index) { @@ -18,11 +19,19 @@ void tagtinker_scene_target_menu_on_enter(void* ctx) { TagTinkerApp* app = ctx; submenu_reset(app->submenu); - submenu_set_header(app->submenu, "Targeted Payloads"); + /* Issue #40: with no saved tag there is no "Set Image" anywhere yet, and + * users looked for their BMPs here. Say what to do first. */ + submenu_set_header( + app->submenu, app->target_count ? "Targeted Payloads" : "Add your tag first"); /* Add new target */ submenu_add_item(app->submenu, "+ Scan NFC", TargetMenuScanNfc, target_menu_cb, app); submenu_add_item(app->submenu, "+ Type Barcode", TargetMenuAddNew, target_menu_cb, app); + if(app->target_count == 0) { + /* Not a command: selecting it does nothing (see on_event). */ + submenu_add_item( + app->submenu, "Then: tag > Set Image", TargetMenuHint, target_menu_cb, app); + } /* List saved targets */ for(uint8_t i = 0; i < app->target_count; i++) { @@ -47,6 +56,10 @@ bool tagtinker_scene_target_menu_on_event(void* ctx, SceneManagerEvent event) { return true; } + if(event.event == TargetMenuHint) { + return true; + } + if(event.event == TargetMenuAddNew) { /* Go to barcode input, then come back */ scene_manager_set_scene_state(