Skip to content

Commit 49ddfa4

Browse files
igerberclaude
andcommitted
Address PR #448 R9 review (1 P3 informational)
StaggeredTripleDifference R reference was wrong. The tracker cited triplediff::staggered_ddd() (planned/non-existent), but the actual R parity assets in benchmarks/R/benchmark_staggered_triplediff.R use the existing triplediff::ddd(panel=TRUE) entrypoint plus agg_ddd() for aggregation. Updated three locations: - Status Summary row: changed R Reference to "triplediff::ddd(panel=TRUE) + agg_ddd()" - Detailed section field table: same with attribution to the benchmark script - "Outstanding for promotion" R-parity bullet: same with attribution No status flips. No estimator, weighting, variance, or inference code changed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent ad41fc1 commit 49ddfa4

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

METHODOLOGY_REVIEW.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ The catalog grew incrementally over several quarters, so formats vary across the
6666
| Estimator | Module | R Reference | Status | Last Review |
6767
|-----------|--------|-------------|--------|-------------|
6868
| TripleDifference | `triple_diff.py` | `triplediff::ddd()` | **Complete** | 2026-02-18 |
69-
| StaggeredTripleDifference | `staggered_triple_diff.py` | `triplediff::staggered_ddd()` (planned) | **In Progress** ||
69+
| StaggeredTripleDifference | `staggered_triple_diff.py` | `triplediff::ddd(panel=TRUE)` + `agg_ddd()` | **In Progress** ||
7070

7171
### Counterfactual / Synthetic Estimators
7272

@@ -797,7 +797,7 @@ and covariate-adjusted specifications.)
797797
|-------|-------|
798798
| Module | `staggered_triple_diff.py`, `staggered_triple_diff_results.py` |
799799
| Primary Reference | Ortiz-Villavicencio & Sant'Anna (2025) — same paper as TripleDifference, staggered case |
800-
| R Reference | `triplediff::staggered_ddd()` (planned) |
800+
| R Reference | `triplediff::ddd(panel=TRUE)` + `agg_ddd()` (per `benchmarks/R/benchmark_staggered_triplediff.R`) |
801801
| Status | **In Progress** |
802802
| Last Review ||
803803

@@ -809,7 +809,7 @@ and covariate-adjusted specifications.)
809809

810810
**Outstanding for promotion:**
811811
- Paper review under `docs/methodology/papers/` covering Ortiz-Villavicencio & Sant'Anna (2025) for the staggered case (the primary paper is shared with TripleDifference, but no dedicated review file exists on disk yet)
812-
- R parity validation against `triplediff::staggered_ddd()` — CSV fixtures not committed (gitignored); tests skip without local R + `triplediff` (tracked in TODO.md row, PR #245)
812+
- R parity validation against `triplediff::ddd(panel=TRUE)` + `agg_ddd()` (per `benchmarks/R/benchmark_staggered_triplediff.R`) — CSV fixtures not committed (gitignored); tests skip without local R + `triplediff` (tracked in TODO.md row, PR #245)
813813
- Per-cohort group-effect SE convention: implementation includes WIF (conservative vs R's `wif=NULL`); documented in REGISTRY, deferred decision on whether to add an opt-in WIF-disable path (tracked in TODO.md row, PR #245)
814814
- Formal Verified Components walk-through here
815815
- Cluster-robust analytical SEs accepted but not wired (deferred per REGISTRY)

0 commit comments

Comments
 (0)