Skip to content

Commit 8652bb9

Browse files
igerberclaude
andcommitted
Resolve placebo_effects deprecation version: 3.6.0 -> 3.5.2
Address CI AI-review P3 (consistency note). The placebo_effects -> variance_effects rename/deprecation (PR #532) ships in THIS release, which is 3.5.2, not the guessed next-minor 3.6.0. Update the `.. deprecated::` Sphinx directive accordingly and drop the now-resolved "assumed next-minor (current is 3.5.1); confirm/resolve at bump-version time" placeholder comment. The v4.0.0 removal target (stated in the warning message) is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 92e545c commit 8652bb9

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

diff_diff/results.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1209,13 +1209,11 @@ def coef_var(self) -> float:
12091209
def placebo_effects(self) -> Optional[np.ndarray]:
12101210
"""Deprecated alias for :attr:`variance_effects` (removed in v4.0.0).
12111211
1212-
.. deprecated:: 3.6.0
1212+
.. deprecated:: 3.5.2
12131213
Renamed to ``variance_effects`` because the array's contents are
12141214
method-specific (placebo effects, bootstrap ATT draws, or
12151215
leave-one-out estimates depending on ``variance_method``).
12161216
"""
1217-
# `3.6.0` is the assumed next-minor (current is 3.5.1); confirm/resolve
1218-
# at bump-version time. The v4.0.0 removal target is fixed.
12191217
warnings.warn(
12201218
"SyntheticDiDResults.placebo_effects is deprecated; use "
12211219
"variance_effects instead. The array holds placebo effects, "

0 commit comments

Comments
 (0)