Commit a86498e
committed
PR #457 R10 polish: case-insensitive R-row selector + refresh golden meta
Fresh R10 verdict was Looks good with 2 P3 informational items:
1. P3 (Maintainability): the always-treated fold-back test selected
R rows via case-sensitive literal substrings ("Untreated",
"Always Treated", "Later"), while the neighboring _classify_r_type
classifier uses case-insensitive semantic matching. Made the
selector consistent — case-insensitive matching on "untreated" /
"never" / "always" tokens, so the fold-back survives bacondecomp
label variation across versions.
2. P3 (Documentation/Tests): committed golden JSON's meta.description
still advertised full per-component (treated, control, type) tuple
parity as the contract, but PR #457 intentionally replaces that for
the always_treated_remapped U-bucket rows with aggregate +
fold-back parity. Updated meta.description to describe the actual
three-tier contract (aggregate / direct per-component on
non-remap + 6 timing-vs-timing rows / cohort fold-back for U
bucket) with a pointer to the REGISTRY Notes that document the
convention divergence.
Tests: 34/34 still pass.1 parent e592a5b commit a86498e
2 files changed
Lines changed: 9 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
519 | 519 | | |
520 | 520 | | |
521 | 521 | | |
522 | | - | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
523 | 526 | | |
524 | 527 | | |
525 | | - | |
526 | | - | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
527 | 532 | | |
528 | 533 | | |
529 | 534 | | |
| |||
0 commit comments