Merge pull request #204 from igerber/reduce-python-ci-tests

Reduce TROP test time in pure Python CI

Author: igerber

.github/workflows/rust-test.yml

@@ -177,4 +177,4 @@ jobs:
           PYTHONPATH=. python -c "from diff_diff import HAS_RUST_BACKEND; print(f'HAS_RUST_BACKEND: {HAS_RUST_BACKEND}'); assert not HAS_RUST_BACKEND"
 
       - name: Run tests in pure Python mode
-        run: PYTHONPATH=. DIFF_DIFF_BACKEND=python pytest tests/ -q --ignore=tests/test_rust_backend.py -n auto --dist worksteal -m ''
+        run: PYTHONPATH=. DIFF_DIFF_BACKEND=python pytest tests/ -q --ignore=tests/test_rust_backend.py -n auto --dist worksteal

CLAUDE.md

@@ -122,9 +122,11 @@ category (`Methodology/Correctness`, `Performance`, or `Testing/Docs`):
   `threshold = 0.40 if n_boot < 100 else 0.15`.
 - **`assert_nan_inference()`** from conftest.py: Use to validate ALL inference fields are
   NaN-consistent. Don't check individual fields separately.
-- **Slow tests**: TROP, Sun-Abraham bootstrap, and TROP-parity tests are marked
-  `@pytest.mark.slow` and excluded by default via `addopts`. Run `pytest -m ''`
-  to include them, or `pytest -m slow` to run only slow tests.
+- **Slow tests**: TROP methodology/joint-method tests, Sun-Abraham bootstrap, and
+  TROP-parity tests are marked `@pytest.mark.slow` and excluded by default via `addopts`.
+  `test_trop.py` uses per-class markers (not file-level) so that validation, API, and
+  solver tests still run in the pure Python CI fallback. Run `pytest -m ''` to include
+  slow tests, or `pytest -m slow` to run only slow tests.
 - **Behavioral assertions**: Always assert expected outcomes, not just no-exception.
   Bad: `result = func(bad_input)`. Good: `result = func(bad_input); assert np.isnan(result.coef)`.
 

tests/test_trop.py

@@ -6,8 +6,6 @@
 import pandas as pd
 import pytest
 
-pytestmark = pytest.mark.slow
-
 from diff_diff import SyntheticDiD
 from diff_diff.trop import TROP, TROPResults, trop
 from diff_diff.prep import generate_factor_data
@@ -465,6 +463,7 @@ def test_nan_propagation_when_se_zero(self):
         assert results.att == 1.0, "ATT should still be valid"
 
 
+@pytest.mark.slow
 class TestTROPvsSDID:
     """Tests comparing TROP to SDID under different DGPs."""
 
@@ -543,6 +542,7 @@ def test_convenience_with_kwargs(self, simple_panel_data):
         assert isinstance(results, TROPResults)
 
 
+@pytest.mark.slow
 class TestMethodologyVerification:
     """Tests verifying TROP methodology matches paper specifications.
 
@@ -1260,6 +1260,7 @@ def test_d_matrix_validation_error_message_helpful(self):
         assert "D[t, i] = 1 for all t >= first treatment" in error_msg
 
 
+@pytest.mark.slow
 class TestCyclingSearch:
     """Tests for LOOCV cycling (coordinate descent) search."""
 
@@ -1348,6 +1349,7 @@ def test_cycling_search_single_value_grids(self, simple_panel_data):
         assert results.lambda_nn == 0.1
 
 
+@pytest.mark.slow
 class TestPaperConformanceFixes:
     """Tests verifying fixes for paper conformance issues.
 
@@ -2716,6 +2718,7 @@ def test_zero_weights_no_division_error(self):
         assert result.shape == (6, 4), f"Expected (6, 4), got {result.shape}"
 
 
+@pytest.mark.slow
 class TestTROPJointMethod:
     """Tests for TROP method='joint'.