Commit f63f40b
Address PR #389 R2 (2 P1 + 1 P2): qug_test scope, design-detection rule, DIDHAD claim
P1 (qug_test in array-in pretest helper list): `docs/api/had.rst:67-72`
listed `qug_test` alongside `stute_test` / `yatchew_hr_test` /
`stute_joint_pretest` as accepting `survey_design=make_pweight_design(weights)`.
Per `had_pretests.py:1236-1255` and the methodology REGISTRY (Phase 4.5 C0
decision gate), `qug_test` permanently raises `NotImplementedError` on any
of `survey_design=` / `survey=` / `weights=` - there is no migration target
for survey-aware QUG, and `make_pweight_design()` is explicitly NOT a valid
QUG migration target. The composite workflow `did_had_pretest_workflow`
handles weighted dispatch by skipping QUG with a `UserWarning`. Removed
`qug_test` from the array-in helper list and added an explicit
permanent-rejection note pointing to the workflow's skip behavior.
P1 (estimand-resolution rule misstatement): `docs/troubleshooting.rst`
"Resolved estimand" subsection said "no exact `dose == 0` => Design 1".
Per `had.py:1932-1987` `_detect_design()` resolves to Design 1' when EITHER
`d.min() == 0` OR `d.min() < 0.01 * median(|d|)` (small-share-of-treated
escape clause). Rewrote the cause to spell out both sub-cases and clarify
that Design 1 only fires when `d.min()` is meaningfully positive relative
to the dose scale. Updated the inspection snippet to compute and print the
`0.01 * median(|d|)` threshold instead of just counting `dose == 0` rows.
P2 (DIDHAD event-study overstatement): `docs/r_comparison.rst` Heterogeneous
Adoption section, R-equivalents note, and Migration Tips bullet claimed
diff-diff additionally covers "the multi-period event-study extension
(paper Appendix B.2)" beyond `DIDHAD`. The `DIDHAD` package already
exposes dynamic effects / placebo / event-study output in the QUG case, so
this overstates the gap. Narrowed all three locations to the documented
differences: Design 1 (no QUG, `WAS_{d_lower}`) and survey-design
integration via Binder TSL.
Sphinx build clean (0 warnings in edited files; the unrelated
`tutorials/18_geo_experiments.ipynb:61` "File not found:
practitioner_decision_tree.html#few-test-markets" warning is pre-existing
on origin/main and not introduced here).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 9a62e92 commit f63f40b
3 files changed
Lines changed: 37 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
68 | | - | |
69 | | - | |
| 68 | + | |
| 69 | + | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
74 | 79 | | |
75 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
225 | 225 | | |
226 | 226 | | |
227 | 227 | | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
236 | 236 | | |
237 | 237 | | |
238 | 238 | | |
| |||
420 | 420 | | |
421 | 421 | | |
422 | 422 | | |
423 | | - | |
424 | | - | |
| 423 | + | |
425 | 424 | | |
426 | 425 | | |
427 | 426 | | |
| |||
439 | 438 | | |
440 | 439 | | |
441 | 440 | | |
442 | | - | |
443 | | - | |
444 | | - | |
| 441 | + | |
| 442 | + | |
445 | 443 | | |
446 | 444 | | |
447 | 445 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
483 | 483 | | |
484 | 484 | | |
485 | 485 | | |
486 | | - | |
487 | | - | |
488 | | - | |
489 | | - | |
490 | | - | |
| 486 | + | |
| 487 | + | |
| 488 | + | |
| 489 | + | |
| 490 | + | |
| 491 | + | |
| 492 | + | |
| 493 | + | |
| 494 | + | |
| 495 | + | |
491 | 496 | | |
492 | 497 | | |
493 | 498 | | |
494 | 499 | | |
495 | 500 | | |
496 | 501 | | |
| 502 | + | |
| 503 | + | |
497 | 504 | | |
498 | | - | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
499 | 508 | | |
500 | 509 | | |
501 | 510 | | |
502 | 511 | | |
503 | 512 | | |
504 | 513 | | |
505 | | - | |
506 | | - | |
507 | | - | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
508 | 517 | | |
509 | 518 | | |
510 | 519 | | |
| |||
0 commit comments