Skip to content

Airports code review #1

Description

@mandyWW

Tosin, I am really impressed with this code, well done!

A few comments below:

  • love the use of pop in the Airports class
  • make line 9 of Airport static as the list of planes belongs to the class as a whole (rather than one instance of Airport)
  • do the tests in Airport test all run? I'm not sure they will..
  • love the suspicious Bag!
  • Bag test - remind me I need to show you how to code to differentiate between no weight and no colour
  • Bag test - add more tests for boundaries e.g. bag weight < 500, = 500, > 500, 0 etc
  • Oooh - I see a jsdoc.conf.json file - cool, would like you to explain this to others in next session!
  • pls add a .gitignore for node_modules and out directory as these should not be version controlled

Any questions pls message me on Slack.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions