Describe the bug
The rotation function
|
def rotate(*args: SimpleNamespace, angle: float, axis: str, system: Union[Opts, None] = None) -> List[SimpleNamespace]: |
has system as an optional input. If it is not provided, the defaults are used. This can lead to lots of problems if the user is not aware of this because the rotated gradients will not adhere to the custom system limits (e.g. gradient raster time).
I don't really see a case where a user would want such a behaviour, i.e. where rotate should lead to a gradient which corresponds to the default system limits rather than the custom system limits of the sequence.
Expected behavior
I think rotate should return an error if system is not provided.
Describe the bug
The
rotationfunctionpypulseq/src/pypulseq/rotate.py
Line 18 in 530c9da
has
systemas an optional input. If it is not provided, the defaults are used. This can lead to lots of problems if the user is not aware of this because the rotated gradients will not adhere to the custom system limits (e.g. gradient raster time).I don't really see a case where a user would want such a behaviour, i.e. where
rotateshould lead to a gradient which corresponds to the default system limits rather than the custom system limits of the sequence.Expected behavior
I think rotate should return an error if system is not provided.