From a221a7475a50b76f7dfc4eb1347bf8db21157982 Mon Sep 17 00:00:00 2001 From: blockmandev <194144408+blockmandev@users.noreply.github.com> Date: Fri, 13 Nov 2026 14:13:30 -0600 Subject: [PATCH] ci: RenderPdf on the Linux runner with its output shown (#22) #22 asks whether RenderPdf on Ubuntu 23.10+ either prints, or says that the browser cannot build its own sandbox and what to do. The tests ran on ubuntu-latest already, but cargo test hides their SKIPPED note, so a pass could not tell which happened. One step reruns the render_pdf tests with --nocapture on Linux, so every run's log shows it. --- .github/workflows/ci.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4fa4845..cc815eb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -174,6 +174,13 @@ jobs: git config --global user.name "ci" - run: cargo clippy --all-targets - run: cargo test --lib + # RenderPdf with the runner's own browser, its output shown (#22): on + # Ubuntu 23.10+ a browser may be unable to build its own sandbox, and + # then incode must say so and what to do instead of printing nothing. + # The test passes either way; this log line is what shows which. + - name: RenderPdf on this runner, output shown + if: runner.os == 'Linux' + run: cargo test --lib render_pdf -- --nocapture --test-threads=1 # The completion tests skip a shell that is missing; here every shell # the runner has is required, so a skip cannot pass for a run. - run: cargo test --bins