Skip to content

Commit 24e8cee

Browse files
amikofalvyinkeep-oss-sync[bot]
authored andcommitted
fix(open-knowledge): drop GitHub follow-up from bug report success dialog (#2668)
The Report a bug success dialog directed users to open a public GitHub issue (a paragraph plus an Open GitHub issue button). The GitHub intake isn't a good follow-up experience right now, so remove that direction. The success screen keeps the report reference and offers writing to support@inkeep.com with it if the user has more to add. GitOrigin-RevId: 4f6b884ba6903d99a6794b43122c79f098a58a47
1 parent 72aa84e commit 24e8cee

7 files changed

Lines changed: 24 additions & 76 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@inkeep/open-knowledge": patch
3+
---
4+
5+
Report a bug no longer points you to GitHub after you send. The "Thanks for the report!" confirmation used to suggest opening a public GitHub issue and included an "Open GitHub issue" button; both are gone. The dialog still shows your report reference to copy, and if you want to add more it offers writing to support@inkeep.com with that reference.

packages/app/src/components/ReportBugDialog.dom.test.tsx

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ describe('ReportBugDialog', () => {
313313
expect((noteBox as HTMLTextAreaElement).value).toBe('my draft note');
314314
});
315315

316-
test('sending uploads the reviewed zip and lands on the reference with copy and GitHub follow-up', async () => {
316+
test('sending uploads the reviewed zip and lands on the reference with copy and support follow-up', async () => {
317317
const send = deferred<OkBugReportSendResult>();
318318
const log = installBridge({ send: () => send.promise });
319319
const { openChangeCalls } = await renderDialog();
@@ -357,15 +357,10 @@ describe('ReportBugDialog', () => {
357357
await screen.findByRole('button', { name: 'Copied!' });
358358
expect(log.clipboard).toEqual(['OK-8H3KQD']);
359359

360-
await userEvent.click(screen.getByRole('button', { name: 'Open GitHub issue' }));
361-
expect(log.opened).toHaveLength(1);
362-
expect(log.opened[0]).toContain('https://github.com/inkeep/open-knowledge/issues/new?');
363-
expect(log.opened[0]).toContain('OK-8H3KQD');
364-
// Privacy pin: the public GitHub prefill carries the reference in title
365-
// and body only — no diagnostics, bundle-path, or attachment params may
366-
// ever ride along.
367-
const issueUrl = new URL(log.opened[0] ?? '');
368-
expect([...issueUrl.searchParams.keys()].sort()).toEqual(['body', 'title']);
360+
// The public GitHub follow-up is gone — no issue button, and support email
361+
// is the only follow-up channel offered.
362+
expect(screen.queryByRole('button', { name: 'Open GitHub issue' })).toBeNull();
363+
expect(screen.getByRole('link', { name: 'support@inkeep.com' })).not.toBeNull();
369364

370365
await userEvent.click(screen.getByRole('button', { name: 'Done' }));
371366
expect(openChangeCalls).toEqual([false]);

packages/app/src/components/ReportBugDialogBody.tsx

Lines changed: 4 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
*
44
* One dialog hosts six phases: compose (optional note + detail level),
55
* review (inspect the exact zip before consenting to send), sending, success
6-
* (report reference + public GitHub follow-up), email (the designed
6+
* (report reference + support-email follow-up), email (the designed
77
* no-intake default — nothing was uploaded, the prefilled draft is the
88
* transport), and failure (the same email fallback framed as an error, for
99
* uploads that were attempted and failed). The zip reviewed is byte-identical
@@ -52,7 +52,6 @@ import { Textarea } from '@/components/ui/textarea';
5252
import { dispatchExternalLinkClick } from '@/lib/external-link';
5353
import { scheduleClipboardWrite } from '@/lib/share/clipboard-adapter';
5454

55-
const GITHUB_NEW_ISSUE_URL = 'https://github.com/inkeep/open-knowledge/issues/new';
5655
const SUPPORT_EMAIL = 'support@inkeep.com';
5756

5857
/** Bare mailto with a prefilled subject — used on the success screen, where the
@@ -351,16 +350,6 @@ function ReportBugDialog({
351350
void window.okDesktop?.shell.openExternal(url);
352351
}
353352

354-
function handleOpenGithubIssue(reference: string) {
355-
const params = new URLSearchParams({
356-
title: t`Bug report ${reference}`,
357-
// The reference is the only private↔public correlation key; the bundle
358-
// itself never leaves the private channel.
359-
body: t`Report reference: ${reference}`,
360-
});
361-
openExternal(`${GITHUB_NEW_ISSUE_URL}?${params}`);
362-
}
363-
364353
const uploadPct = Math.round(sentFraction * 100);
365354

366355
return (
@@ -763,21 +752,14 @@ function ReportBugDialog({
763752
</div>
764753
<p className="text-sm text-muted-foreground">
765754
<Trans>
766-
<span className="font-medium text-foreground">Want to follow along?</span> Open
767-
a GitHub issue and mention your reference. Or write to{' '}
768-
<SupportEmailLink href={supportMailtoUrl(t`Bug report ${phase.reference}`)} />
755+
<span className="font-medium text-foreground">Have more to add?</span> Write to{' '}
756+
<SupportEmailLink href={supportMailtoUrl(t`Bug report ${phase.reference}`)} />{' '}
757+
and mention your reference.
769758
</Trans>
770759
</p>
771760
</div>
772761
</DialogBody>
773762
<DialogFooter>
774-
<Button
775-
variant="outline"
776-
className="font-mono uppercase"
777-
onClick={() => handleOpenGithubIssue(phase.reference)}
778-
>
779-
<Trans>Open GitHub issue</Trans>
780-
</Button>
781763
<Button onClick={() => handleOpenChange(false)}>
782764
<Trans>Done</Trans>
783765
</Button>

packages/app/src/locales/en/messages.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -719,9 +719,6 @@
719719
],
720720
"FEqWFL": ["Guides your AI agents on how to work here."],
721721
"FEr96N": ["Theme"],
722-
"FHSN1Z": [
723-
"<0>Want to follow along?</0> Open a GitHub issue and mention your reference. Or write to <1/>"
724-
],
725722
"FNTx6u": ["Search \"", ["semanticSubmitQuery"], "\" by meaning"],
726723
"FOGD7m": ["Create something great."],
727724
"FRYB1Q": ["/api/config returned a malformed body"],
@@ -844,7 +841,6 @@
844841
"ICoNYz": ["You can also manage this in Settings."],
845842
"IFezUv": ["The audit could not be completed. Try again."],
846843
"IInnZo": ["Conflict"],
847-
"IKkfn_": ["Report reference: ", ["reference"]],
848844
"IKoTAC": ["Keep disabled"],
849845
"IN4UX8": ["Search (", ["searchShortcut"], ")"],
850846
"IQPyrD": ["Missing page — click to create"],
@@ -1178,7 +1174,6 @@
11781174
"PrJYSN": ["This folder isn't on GitHub yet. The link won't work until it's pushed."],
11791175
"PrhzDE": ["Pan up"],
11801176
"Pyp1NA": ["Restore to this point?"],
1181-
"PzUvDM": ["Bug report ", ["reference"]],
11821177
"Q5fqMz": ["Connection error — try again"],
11831178
"Q6hhn8": ["Preferences"],
11841179
"Q7W-mC": ["Same folder as current file"],
@@ -1535,7 +1530,6 @@
15351530
"YsEYYS": [
15361531
["behind", "plural", { "one": ["#", " commit behind"], "other": ["#", " commits behind"] }]
15371532
],
1538-
"Yu3KMH": ["Open GitHub issue"],
15391533
"YwPUUP": ["This pack is already set up here."],
15401534
"YyXtnN": ["Underline"],
15411535
"Z1LF1M": ["Sharing a doc needs a GitHub repository. Create one for this project."],
@@ -1849,6 +1843,7 @@
18491843
"fqSfXY": ["Replace"],
18501844
"fuJZKk": ["Search branches"],
18511845
"fwhX-N": ["Indent or outdent source"],
1846+
"fxJk_6": ["<0>Have more to add?</0> Write to <1/> and mention your reference."],
18521847
"fxbCNQ": ["Synced. The link is up to date."],
18531848
"g3UF2V": ["Accept"],
18541849
"g4WlQK": ["Project AI tool management is only available in the OpenKnowledge desktop app."],

packages/app/src/locales/en/messages.po

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -573,6 +573,10 @@ msgstr "<{descriptorLabel}> failed to render (likely a bad prop). Copy the sourc
573573
msgid "<0>~/.ok/bin</0> and <1>~/.ok/env.sh</1> stay either way — the app always maintains them."
574574
msgstr "<0>~/.ok/bin</0> and <1>~/.ok/env.sh</1> stay either way — the app always maintains them."
575575

576+
#: src/components/ReportBugDialogBody.tsx
577+
msgid "<0>Have more to add?</0> Write to <1/> and mention your reference."
578+
msgstr "<0>Have more to add?</0> Write to <1/> and mention your reference."
579+
576580
#: src/editor/components/Mirror.tsx
577581
msgid "<0>Mirror — pick a source.</0> Set <1>src</1> + <2>anchor</2> via the property panel to point at a <3><MirrorSource></3> elsewhere."
578582
msgstr "<0>Mirror — pick a source.</0> Set <1>src</1> + <2>anchor</2> via the property panel to point at a <3><MirrorSource></3> elsewhere."
@@ -590,10 +594,6 @@ msgstr "<0>Mirror source removed.</0> The doc <1>{src}</1> is no longer availabl
590594
msgid "<0>ok</0> won't run in external terminals until you add it later from the File menu. OpenKnowledge's built-in terminal and AI tools keep working."
591595
msgstr "<0>ok</0> won't run in external terminals until you add it later from the File menu. OpenKnowledge's built-in terminal and AI tools keep working."
592596

593-
#: src/components/ReportBugDialogBody.tsx
594-
msgid "<0>Want to follow along?</0> Open a GitHub issue and mention your reference. Or write to <1/>"
595-
msgstr "<0>Want to follow along?</0> Open a GitHub issue and mention your reference. Or write to <1/>"
596-
597597
#: src/components/PageHeaderWidgets.tsx
598598
msgid "📝 or assets/icon.png"
599599
msgstr "📝 or assets/icon.png"
@@ -1290,10 +1290,6 @@ msgstr "Browse your repos:"
12901290
msgid "Bug report {0}"
12911291
msgstr "Bug report {0}"
12921292

1293-
#: src/components/ReportBugDialogBody.tsx
1294-
msgid "Bug report {reference}"
1295-
msgstr "Bug report {reference}"
1296-
12971293
#: src/components/ReportBugDialogBody.tsx
12981294
msgid "Bug reporting needs the OpenKnowledge desktop app."
12991295
msgstr "Bug reporting needs the OpenKnowledge desktop app."
@@ -5434,10 +5430,6 @@ msgstr "Open folder"
54345430
msgid "Open folder on disk"
54355431
msgstr "Open folder on disk"
54365432

5437-
#: src/components/ReportBugDialogBody.tsx
5438-
msgid "Open GitHub issue"
5439-
msgstr "Open GitHub issue"
5440-
54415433
#: src/components/CommandPalette.tsx
54425434
msgid "Open graph"
54435435
msgstr "Open graph"
@@ -6354,10 +6346,6 @@ msgstr "Report a bug"
63546346
msgid "Report reference"
63556347
msgstr "Report reference"
63566348

6357-
#: src/components/ReportBugDialogBody.tsx
6358-
msgid "Report reference: {reference}"
6359-
msgstr "Report reference: {reference}"
6360-
63616349
#: src/components/AppErrorBoundary.tsx
63626350
#: src/components/DocumentErrorBoundary.tsx
63636351
msgid "Report this error"

packages/app/src/locales/pseudo/messages.json

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -719,9 +719,6 @@
719719
],
720720
"FEqWFL": ["Ĝũĩďēś ŷōũŕ ÀĨ àĝēńţś ōń ĥōŵ ţō ŵōŕķ ĥēŕē."],
721721
"FEr96N": ["Ţĥēḿē"],
722-
"FHSN1Z": [
723-
"<0>Ŵàńţ ţō ƒōĺĺōŵ àĺōńĝ?</0> Ōƥēń à ĜĩţĤũƀ ĩśśũē àńď ḿēńţĩōń ŷōũŕ ŕēƒēŕēńćē. Ōŕ ŵŕĩţē ţō <1/>"
724-
],
725722
"FNTx6u": ["Śēàŕćĥ \"", ["semanticSubmitQuery"], "\" ƀŷ ḿēàńĩńĝ"],
726723
"FOGD7m": ["Ćŕēàţē śōḿēţĥĩńĝ ĝŕēàţ."],
727724
"FRYB1Q": ["/àƥĩ/ćōńƒĩĝ ŕēţũŕńēď à ḿàĺƒōŕḿēď ƀōďŷ"],
@@ -844,7 +841,6 @@
844841
"ICoNYz": ["Ŷōũ ćàń àĺśō ḿàńàĝē ţĥĩś ĩń Śēţţĩńĝś."],
845842
"IFezUv": ["Ţĥē àũďĩţ ćōũĺď ńōţ ƀē ćōḿƥĺēţēď. Ţŕŷ àĝàĩń."],
846843
"IInnZo": ["Ćōńƒĺĩćţ"],
847-
"IKkfn_": ["Ŕēƥōŕţ ŕēƒēŕēńćē: ", ["reference"]],
848844
"IKoTAC": ["Ķēēƥ ďĩśàƀĺēď"],
849845
"IN4UX8": ["Śēàŕćĥ (", ["searchShortcut"], ")"],
850846
"IQPyrD": ["Ḿĩśśĩńĝ ƥàĝē — ćĺĩćķ ţō ćŕēàţē"],
@@ -1178,7 +1174,6 @@
11781174
"PrJYSN": ["Ţĥĩś ƒōĺďēŕ ĩśń'ţ ōń ĜĩţĤũƀ ŷēţ. Ţĥē ĺĩńķ ŵōń'ţ ŵōŕķ ũńţĩĺ ĩţ'ś ƥũśĥēď."],
11791175
"PrhzDE": ["Ƥàń ũƥ"],
11801176
"Pyp1NA": ["Ŕēśţōŕē ţō ţĥĩś ƥōĩńţ?"],
1181-
"PzUvDM": ["ßũĝ ŕēƥōŕţ ", ["reference"]],
11821177
"Q5fqMz": ["Ćōńńēćţĩōń ēŕŕōŕ — ţŕŷ àĝàĩń"],
11831178
"Q6hhn8": ["Ƥŕēƒēŕēńćēś"],
11841179
"Q7W-mC": ["Śàḿē ƒōĺďēŕ àś ćũŕŕēńţ ƒĩĺē"],
@@ -1535,7 +1530,6 @@
15351530
"YsEYYS": [
15361531
["behind", "plural", { "one": ["#", " ćōḿḿĩţ ƀēĥĩńď"], "other": ["#", " ćōḿḿĩţś ƀēĥĩńď"] }]
15371532
],
1538-
"Yu3KMH": ["Ōƥēń ĜĩţĤũƀ ĩśśũē"],
15391533
"YwPUUP": ["Ţĥĩś ƥàćķ ĩś àĺŕēàďŷ śēţ ũƥ ĥēŕē."],
15401534
"YyXtnN": ["Ũńďēŕĺĩńē"],
15411535
"Z1LF1M": ["Śĥàŕĩńĝ à ďōć ńēēďś à ĜĩţĤũƀ ŕēƥōśĩţōŕŷ. Ćŕēàţē ōńē ƒōŕ ţĥĩś ƥŕōĴēćţ."],
@@ -1849,6 +1843,7 @@
18491843
"fqSfXY": ["Ŕēƥĺàćē"],
18501844
"fuJZKk": ["Śēàŕćĥ ƀŕàńćĥēś"],
18511845
"fwhX-N": ["Ĩńďēńţ ōŕ ōũţďēńţ śōũŕćē"],
1846+
"fxJk_6": ["<0>Ĥàvē ḿōŕē ţō àďď?</0> Ŵŕĩţē ţō <1/> àńď ḿēńţĩōń ŷōũŕ ŕēƒēŕēńćē."],
18521847
"fxbCNQ": ["Śŷńćēď. Ţĥē ĺĩńķ ĩś ũƥ ţō ďàţē."],
18531848
"g3UF2V": ["Àććēƥţ"],
18541849
"g4WlQK": ["ƤŕōĴēćţ ÀĨ ţōōĺ ḿàńàĝēḿēńţ ĩś ōńĺŷ àvàĩĺàƀĺē ĩń ţĥē ŌƥēńĶńōŵĺēďĝē ďēśķţōƥ àƥƥ."],

packages/app/src/locales/pseudo/messages.po

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,10 @@ msgstr ""
568568
msgid "<0>~/.ok/bin</0> and <1>~/.ok/env.sh</1> stay either way — the app always maintains them."
569569
msgstr ""
570570

571+
#: src/components/ReportBugDialogBody.tsx
572+
msgid "<0>Have more to add?</0> Write to <1/> and mention your reference."
573+
msgstr ""
574+
571575
#: src/editor/components/Mirror.tsx
572576
msgid "<0>Mirror — pick a source.</0> Set <1>src</1> + <2>anchor</2> via the property panel to point at a <3><MirrorSource></3> elsewhere."
573577
msgstr ""
@@ -585,10 +589,6 @@ msgstr ""
585589
msgid "<0>ok</0> won't run in external terminals until you add it later from the File menu. OpenKnowledge's built-in terminal and AI tools keep working."
586590
msgstr ""
587591

588-
#: src/components/ReportBugDialogBody.tsx
589-
msgid "<0>Want to follow along?</0> Open a GitHub issue and mention your reference. Or write to <1/>"
590-
msgstr ""
591-
592592
#: src/components/PageHeaderWidgets.tsx
593593
msgid "📝 or assets/icon.png"
594594
msgstr ""
@@ -1285,10 +1285,6 @@ msgstr ""
12851285
msgid "Bug report {0}"
12861286
msgstr ""
12871287

1288-
#: src/components/ReportBugDialogBody.tsx
1289-
msgid "Bug report {reference}"
1290-
msgstr ""
1291-
12921288
#: src/components/ReportBugDialogBody.tsx
12931289
msgid "Bug reporting needs the OpenKnowledge desktop app."
12941290
msgstr ""
@@ -5429,10 +5425,6 @@ msgstr ""
54295425
msgid "Open folder on disk"
54305426
msgstr ""
54315427

5432-
#: src/components/ReportBugDialogBody.tsx
5433-
msgid "Open GitHub issue"
5434-
msgstr ""
5435-
54365428
#: src/components/CommandPalette.tsx
54375429
msgid "Open graph"
54385430
msgstr ""
@@ -6349,10 +6341,6 @@ msgstr ""
63496341
msgid "Report reference"
63506342
msgstr ""
63516343

6352-
#: src/components/ReportBugDialogBody.tsx
6353-
msgid "Report reference: {reference}"
6354-
msgstr ""
6355-
63566344
#: src/components/AppErrorBoundary.tsx
63576345
#: src/components/DocumentErrorBoundary.tsx
63586346
msgid "Report this error"

0 commit comments

Comments
 (0)