From 3bd332113765910bb9e3037116027be14109c955 Mon Sep 17 00:00:00 2001
From: miles-kt-inkeep <135626743+miles-kt-inkeep@users.noreply.github.com>
Date: Wed, 17 Jun 2026 17:42:25 -0400
Subject: [PATCH] feat(open-knowledge): publish-to-GitHub owner radio with org
 default (#1932)

* feat(open-knowledge): publish-to-GitHub owner radio with org default

Render the Publish to GitHub owner picker as a radio list instead of a
dropdown, and pre-select the first organization the user can publish into,
falling back to the personal account when there is no org.

* chore(open-knowledge): target published CLI package in changeset

Address review: user-facing app UI features target the published
@inkeep/open-knowledge package (not the private app package) so the
change surfaces in the consumer-visible changelog. Fixed group bumps all
packages in lockstep regardless.

* fix(open-knowledge): label publish radios via aria-labelledby

Address review: the Owner and Visibility group labels were orphaned
<label> elements with their text duplicated in aria-label. Point each
RadioGroup at its visible Label via aria-labelledby so screen readers get
a single source of truth.

* feat(open-knowledge): drop owner-kind subtext from publish radios

Remove the per-owner "Your account"/"Organization" caption under each
owner radio; the login alone is enough and the cards read cleaner.

GitOrigin-RevId: 2468fd50c4606fc4b8fef6d5b0aacbc789c47966
---
 .changeset/publish-owner-radio-default-org.md |  7 ++
 .../PublishToGitHubDialog.dom.test.tsx        | 43 +++++++++-
 .../src/components/PublishToGitHubDialog.tsx  | 85 +++++++++----------
 .../app/src/lib/share/publish-wizard.test.ts  | 24 ++++++
 packages/app/src/lib/share/publish-wizard.ts  |  5 ++
 packages/app/src/locales/en/messages.json     |  3 -
 packages/app/src/locales/en/messages.po       | 12 ---
 packages/app/src/locales/pseudo/messages.json |  3 -
 packages/app/src/locales/pseudo/messages.po   | 12 ---
 9 files changed, 117 insertions(+), 77 deletions(-)
 create mode 100644 .changeset/publish-owner-radio-default-org.md

diff --git a/.changeset/publish-owner-radio-default-org.md b/.changeset/publish-owner-radio-default-org.md
new file mode 100644
index 000000000..9680d8349
--- /dev/null
+++ b/.changeset/publish-owner-radio-default-org.md
@@ -0,0 +1,7 @@
+---
+"@inkeep/open-knowledge": patch
+---
+
+Publish-to-GitHub: pick the owner with a radio list and default to an org
+
+The "Publish to GitHub" dialog now renders the eligible owners as a radio list (one card per owner) instead of a dropdown, so every choice is visible at a glance. When you belong to one or more organizations the wizard pre-selects the first org rather than your personal account, since a knowledge base is far more likely meant for the team, and accidentally publishing it under a personal login is annoying to undo. With no org available it falls back to your own account as before.
diff --git a/packages/app/src/components/PublishToGitHubDialog.dom.test.tsx b/packages/app/src/components/PublishToGitHubDialog.dom.test.tsx
index 3aea73d22..87abe7a4e 100644
--- a/packages/app/src/components/PublishToGitHubDialog.dom.test.tsx
+++ b/packages/app/src/components/PublishToGitHubDialog.dom.test.tsx
@@ -129,6 +129,8 @@ mock.module('@/lib/share/publish-wizard', () => ({
   extractFolderBasename: (path: string) => path.split('/').filter(Boolean).at(-1) ?? '',
   fetchPublishNameCheck: fetchPublishNameCheckMock,
   fetchPublishOwners: fetchPublishOwnersMock,
+  pickDefaultOwner: (owners: SharePublishOwner[]) =>
+    owners.find((o) => o.kind === 'org')?.login ?? owners[0]?.login ?? '',
   presentPublishError: () => presentError,
   resolveNameCheckStatus: (_result: unknown, owner: string, name: string) => ({
     kind: 'available' as const,
@@ -212,7 +214,13 @@ describe('PublishToGitHubDialog runtime behavior', () => {
     await renderDialog();
 
     expect(screen.getByRole('dialog', { name: 'Publish to GitHub' })).toBeTruthy();
-    expect(await screen.findByTestId('publish-owner-trigger')).toBeTruthy();
+    expect(await screen.findByTestId('publish-owner-radio')).toBeTruthy();
+    expect(screen.getByTestId('publish-owner-option-docs-team').getAttribute('data-state')).toBe(
+      'checked',
+    );
+    expect(screen.getByTestId('publish-owner-option-alice').getAttribute('data-state')).toBe(
+      'unchecked',
+    );
     expect((screen.getByTestId('publish-name') as HTMLInputElement).value).toBe('my-project');
     expect(screen.getByText('Will be created as')).toBeTruthy();
     expect(screen.getByText('my-project')).toBeTruthy();
@@ -232,6 +240,37 @@ describe('PublishToGitHubDialog runtime behavior', () => {
     expect((screen.getByTestId('publish-submit') as HTMLButtonElement).disabled).toBe(false);
   });
 
+  test('pre-selects the user account when no org is available', async () => {
+    ownersQueue = [{ ok: true, owners: [{ kind: 'user', login: 'alice' }] }];
+    await renderDialog();
+
+    expect(await screen.findByTestId('publish-owner-radio')).toBeTruthy();
+    expect(screen.getByTestId('publish-owner-option-alice').getAttribute('data-state')).toBe(
+      'checked',
+    );
+    await waitForAvailableNameCheck();
+    await userEvent.click(screen.getByTestId('publish-submit'));
+
+    await waitFor(() => expect(submitCalls).toHaveLength(1));
+    expect(submitCalls[0]?.owner).toBe('alice');
+  });
+
+  test('selecting a different owner radio updates the publish payload', async () => {
+    const { onOpenChange } = await renderDialog();
+    await waitForAvailableNameCheck();
+
+    await userEvent.click(screen.getByTestId('publish-owner-option-alice'));
+    expect(screen.getByTestId('publish-owner-option-alice').getAttribute('data-state')).toBe(
+      'checked',
+    );
+    await waitForAvailableNameCheck();
+    await userEvent.click(screen.getByTestId('publish-submit'));
+
+    await waitFor(() => expect(submitCalls).toHaveLength(1));
+    expect(submitCalls[0]?.owner).toBe('alice');
+    expect(onOpenChange).not.toHaveBeenCalledWith(false);
+  });
+
   test('submits through publish helpers, shows success URL, copies from a fresh button click, and Done closes', async () => {
     const { onOpenChange } = await renderDialog();
     await waitForAvailableNameCheck();
@@ -246,7 +285,7 @@ describe('PublishToGitHubDialog runtime behavior', () => {
       {
         description: 'Internal docs',
         name: 'my-project',
-        owner: 'alice',
+        owner: 'docs-team',
         visibility: 'private',
       },
     ]);
diff --git a/packages/app/src/components/PublishToGitHubDialog.tsx b/packages/app/src/components/PublishToGitHubDialog.tsx
index 400615419..6f71620ca 100644
--- a/packages/app/src/components/PublishToGitHubDialog.tsx
+++ b/packages/app/src/components/PublishToGitHubDialog.tsx
@@ -24,13 +24,6 @@ import {
 import { Input } from '@/components/ui/input';
 import { Label } from '@/components/ui/label';
 import { RadioGroup, RadioGroupItem } from '@/components/ui/radio-group';
-import {
-  Select,
-  SelectContent,
-  SelectItem,
-  SelectTrigger,
-  SelectValue,
-} from '@/components/ui/select';
 import { Textarea } from '@/components/ui/textarea';
 import { useDocumentContext } from '@/editor/DocumentContext';
 import { docNameToMarkdownPath } from '@/lib/doc-paths';
@@ -41,6 +34,7 @@ import {
   fetchPublishNameCheck,
   fetchPublishOwners,
   type NameCheckStatus,
+  pickDefaultOwner,
   presentPublishError,
   resolveNameCheckStatus,
   sanitizeRepoName,
@@ -107,7 +101,7 @@ export function PublishToGitHubDialog({ open, onOpenChange }: PublishToGitHubDia
       }
       setOwners(res.owners);
       if (res.owners.length > 0 && selectedOwner === '') {
-        setSelectedOwner(res.owners[0]?.login ?? '');
+        setSelectedOwner(pickDefaultOwner(res.owners));
       }
     } catch {
       setOwnersError(t`Couldn't reach GitHub. Try again?`);
@@ -133,7 +127,7 @@ export function PublishToGitHubDialog({ open, onOpenChange }: PublishToGitHubDia
     if (owners === null) {
       void loadOwners();
     } else if (selectedOwner === '' && owners.length > 0) {
-      setSelectedOwner(owners[0]?.login ?? '');
+      setSelectedOwner(pickDefaultOwner(owners));
     }
   }, [open]);
 
@@ -309,7 +303,7 @@ export function PublishToGitHubDialog({ open, onOpenChange }: PublishToGitHubDia
 
               <DialogBody className="flex flex-col gap-6">
                 <fieldset className="flex flex-col gap-2">
-                  <Label htmlFor="publish-owner">
+                  <Label id="publish-owner-label">
                     <Trans>Owner</Trans>
                   </Label>
                   {ownersLoading && owners === null ? (
@@ -330,39 +324,40 @@ export function PublishToGitHubDialog({ open, onOpenChange }: PublishToGitHubDia
                       </Button>
                     </div>
                   ) : (
-                    <Select value={selectedOwner} onValueChange={setSelectedOwner}>
-                      <SelectTrigger
-                        id="publish-owner"
-                        data-testid="publish-owner-trigger"
-                        aria-label={t`Owner`}
-                      >
-                        <SelectValue placeholder={t`Pick an owner`} />
-                      </SelectTrigger>
-                      <SelectContent>
-                        {(owners ?? []).map((o) => (
-                          <SelectItem
-                            key={o.login}
-                            value={o.login}
-                            data-testid={`publish-owner-option-${o.login}`}
-                          >
-                            <span className="flex items-center gap-2">
-                              {o.avatarUrl ? (
-                                <img
-                                  src={o.avatarUrl}
-                                  alt=""
-                                  aria-hidden
-                                  className="size-4 rounded-full"
-                                />
-                              ) : null}
-                              <span>{o.login}</span>
-                              <span className="text-xs text-muted-foreground">
-                                {o.kind === 'user' ? <Trans>you</Trans> : <Trans>org</Trans>}
-                              </span>
-                            </span>
-                          </SelectItem>
-                        ))}
-                      </SelectContent>
-                    </Select>
+                    <RadioGroup
+                      value={selectedOwner}
+                      onValueChange={setSelectedOwner}
+                      aria-labelledby="publish-owner-label"
+                      data-testid="publish-owner-radio"
+                    >
+                      {(owners ?? []).map((o) => {
+                        const itemId = `publish-owner-${o.login}`;
+                        return (
+                          <FieldLabel key={o.login} htmlFor={itemId}>
+                            <Field orientation="horizontal">
+                              <FieldContent>
+                                <FieldTitle>
+                                  {o.avatarUrl ? (
+                                    <img
+                                      src={o.avatarUrl}
+                                      alt=""
+                                      aria-hidden
+                                      className="size-4 rounded-full"
+                                    />
+                                  ) : null}
+                                  <span>{o.login}</span>
+                                </FieldTitle>
+                              </FieldContent>
+                              <RadioGroupItem
+                                value={o.login}
+                                id={itemId}
+                                data-testid={`publish-owner-option-${o.login}`}
+                              />
+                            </Field>
+                          </FieldLabel>
+                        );
+                      })}
+                    </RadioGroup>
                   )}
                 </fieldset>
 
@@ -401,7 +396,7 @@ export function PublishToGitHubDialog({ open, onOpenChange }: PublishToGitHubDia
                 </fieldset>
 
                 <fieldset className="flex flex-col gap-2">
-                  <Label>
+                  <Label id="publish-visibility-label">
                     <Trans>Visibility</Trans>
                   </Label>
                   <RadioGroup
@@ -410,7 +405,7 @@ export function PublishToGitHubDialog({ open, onOpenChange }: PublishToGitHubDia
                       setVisibility(value === 'public' ? 'public' : 'private')
                     }
                     className="sm:flex"
-                    aria-label={t`Visibility`}
+                    aria-labelledby="publish-visibility-label"
                   >
                     <FieldLabel htmlFor="publish-visibility-private">
                       <Field orientation="horizontal">
diff --git a/packages/app/src/lib/share/publish-wizard.test.ts b/packages/app/src/lib/share/publish-wizard.test.ts
index cdacb69ff..7b3853de3 100644
--- a/packages/app/src/lib/share/publish-wizard.test.ts
+++ b/packages/app/src/lib/share/publish-wizard.test.ts
@@ -1,10 +1,12 @@
 import { describe, expect, mock, test } from 'bun:test';
+import type { SharePublishOwner } from '@inkeep/open-knowledge-core';
 import {
   buildSamlSsoAuthorizeUrl,
   canSubmitPublish,
   extractFolderBasename,
   fetchPublishNameCheck,
   fetchPublishOwners,
+  pickDefaultOwner,
   presentPublishError,
   resolveNameCheckStatus,
   sanitizeRepoName,
@@ -61,6 +63,28 @@ describe('extractFolderBasename', () => {
   });
 });
 
+describe('pickDefaultOwner', () => {
+  const user: SharePublishOwner = { login: 'alice', kind: 'user' };
+  const orgA: SharePublishOwner = { login: 'docs-team', kind: 'org' };
+  const orgB: SharePublishOwner = { login: 'platform', kind: 'org' };
+
+  test('prefers the first org over the user account', () => {
+    expect(pickDefaultOwner([user, orgA, orgB])).toBe('docs-team');
+  });
+
+  test('falls back to the user account when there is no org', () => {
+    expect(pickDefaultOwner([user])).toBe('alice');
+  });
+
+  test('returns the first entry when somehow ordered with no org', () => {
+    expect(pickDefaultOwner([orgA, orgB])).toBe('docs-team');
+  });
+
+  test('empty list yields empty string', () => {
+    expect(pickDefaultOwner([])).toBe('');
+  });
+});
+
 describe('buildSamlSsoAuthorizeUrl', () => {
   test('builds the GitHub org-policies-applications URL', () => {
     expect(buildSamlSsoAuthorizeUrl('inkeep')).toBe(
diff --git a/packages/app/src/lib/share/publish-wizard.ts b/packages/app/src/lib/share/publish-wizard.ts
index ec9a99ff4..1c826b35b 100644
--- a/packages/app/src/lib/share/publish-wizard.ts
+++ b/packages/app/src/lib/share/publish-wizard.ts
@@ -27,6 +27,11 @@ export function sanitizeRepoName(input: string): string {
 
 export { extractFolderBasename } from '@/lib/path-utils';
 
+export function pickDefaultOwner(owners: SharePublishOwner[]): string {
+  const firstOrg = owners.find((o) => o.kind === 'org');
+  return firstOrg?.login ?? owners[0]?.login ?? '';
+}
+
 export function buildSamlSsoAuthorizeUrl(orgLogin: string): string {
   return `https://github.com/orgs/${encodeURIComponent(orgLogin)}/policies/applications`;
 }
diff --git a/packages/app/src/locales/en/messages.json b/packages/app/src/locales/en/messages.json
index f6d25b7f7..f154555fa 100644
--- a/packages/app/src/locales/en/messages.json
+++ b/packages/app/src/locales/en/messages.json
@@ -308,7 +308,6 @@
     "8TLE9g": [
       "Read-only copy of a MirrorSource block from another doc. Edit at the source — every Mirror reflects the change live."
     ],
-    "8XQ7Ib": ["Pick an owner"],
     "8XQRON": ["Loading repositories"],
     "8_brI5": ["Name is required"],
     "8cS0nH": ["Config sharing unavailable: ", ["0"], "."],
@@ -1114,7 +1113,6 @@
       "."
     ],
     "_K2CvV": ["Template"],
-    "_N2eSU": ["org"],
     "_PACVa": ["Release notes"],
     "_QwkMu": ["No matching paths"],
     "_TDESN": ["Network error - ", ["kind"], " \"", ["createdPath"], "\" still exists on disk"],
@@ -1156,7 +1154,6 @@
     "aiArms": ["We couldn't clone this repository."],
     "ajz9F8": ["Couldn't load conflict content for ", ["filePath"], ". Try reloading the page."],
     "aoa6xA": ["network error (is `ok ui` running?)"],
-    "av_PD9": ["you"],
     "b3Thhd": ["Upload failed"],
     "b4AQFK": ["Open activity panel for ", ["tooltipName"], ", editing ", ["realCurrentDoc"]],
     "b4itZn": ["Working"],
diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.po
index b07003d2e..cdf5d7150 100644
--- a/packages/app/src/locales/en/messages.po
+++ b/packages/app/src/locales/en/messages.po
@@ -4071,10 +4071,6 @@ msgstr "Ordered list"
 msgid "Ordered List"
 msgstr "Ordered List"
 
-#: src/components/PublishToGitHubDialog.tsx
-msgid "org"
-msgstr "org"
-
 #: src/components/GraphPanel.tsx
 msgid "Orphan mode"
 msgstr "Orphan mode"
@@ -4246,10 +4242,6 @@ msgstr "Pick a name"
 msgid "Pick a starter pack to scaffold folders, templates, and AI-readable rules."
 msgstr "Pick a starter pack to scaffold folders, templates, and AI-readable rules."
 
-#: src/components/PublishToGitHubDialog.tsx
-msgid "Pick an owner"
-msgstr "Pick an owner"
-
 #: src/components/ShareReceiveDialog.tsx
 msgid "Pick the folder where you've cloned it."
 msgstr "Pick the folder where you've cloned it."
@@ -6159,10 +6151,6 @@ msgstr "writing"
 msgid "yesterday"
 msgstr "yesterday"
 
-#: src/components/PublishToGitHubDialog.tsx
-msgid "you"
-msgstr "you"
-
 #: src/components/TerminalGate.tsx
 msgid "You can also manage this in Settings."
 msgstr "You can also manage this in Settings."
diff --git a/packages/app/src/locales/pseudo/messages.json b/packages/app/src/locales/pseudo/messages.json
index 5bcbd1cf2..5c531e836 100644
--- a/packages/app/src/locales/pseudo/messages.json
+++ b/packages/app/src/locales/pseudo/messages.json
@@ -308,7 +308,6 @@
     "8TLE9g": [
       "Ŕēàď-ōńĺŷ ćōƥŷ ōƒ à ḾĩŕŕōŕŚōũŕćē ƀĺōćķ ƒŕōḿ àńōţĥēŕ ďōć. Ēďĩţ àţ ţĥē śōũŕćē — ēvēŕŷ Ḿĩŕŕōŕ ŕēƒĺēćţś ţĥē ćĥàńĝē ĺĩvē."
     ],
-    "8XQ7Ib": ["Ƥĩćķ àń ōŵńēŕ"],
     "8XQRON": ["Ĺōàďĩńĝ ŕēƥōśĩţōŕĩēś"],
     "8_brI5": ["Ńàḿē ĩś ŕēǫũĩŕēď"],
     "8cS0nH": ["Ćōńƒĩĝ śĥàŕĩńĝ ũńàvàĩĺàƀĺē: ", ["0"], "."],
@@ -1114,7 +1113,6 @@
       "."
     ],
     "_K2CvV": ["Ţēḿƥĺàţē"],
-    "_N2eSU": ["ōŕĝ"],
     "_PACVa": ["Ŕēĺēàśē ńōţēś"],
     "_QwkMu": ["Ńō ḿàţćĥĩńĝ ƥàţĥś"],
     "_TDESN": ["Ńēţŵōŕķ ēŕŕōŕ - ", ["kind"], " \"", ["createdPath"], "\" śţĩĺĺ ēxĩśţś ōń ďĩśķ"],
@@ -1156,7 +1154,6 @@
     "aiArms": ["Ŵē ćōũĺďń'ţ ćĺōńē ţĥĩś ŕēƥōśĩţōŕŷ."],
     "ajz9F8": ["Ćōũĺďń'ţ ĺōàď ćōńƒĺĩćţ ćōńţēńţ ƒōŕ ", ["filePath"], ". Ţŕŷ ŕēĺōàďĩńĝ ţĥē ƥàĝē."],
     "aoa6xA": ["ńēţŵōŕķ ēŕŕōŕ (ĩś `ōķ ũĩ` ŕũńńĩńĝ?)"],
-    "av_PD9": ["ŷōũ"],
     "b3Thhd": ["Ũƥĺōàď ƒàĩĺēď"],
     "b4AQFK": ["Ōƥēń àćţĩvĩţŷ ƥàńēĺ ƒōŕ ", ["tooltipName"], ", ēďĩţĩńĝ ", ["realCurrentDoc"]],
     "b4itZn": ["Ŵōŕķĩńĝ"],
diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.po
index 53e583ef5..4bb0b6265 100644
--- a/packages/app/src/locales/pseudo/messages.po
+++ b/packages/app/src/locales/pseudo/messages.po
@@ -4066,10 +4066,6 @@ msgstr ""
 msgid "Ordered List"
 msgstr ""
 
-#: src/components/PublishToGitHubDialog.tsx
-msgid "org"
-msgstr ""
-
 #: src/components/GraphPanel.tsx
 msgid "Orphan mode"
 msgstr ""
@@ -4241,10 +4237,6 @@ msgstr ""
 msgid "Pick a starter pack to scaffold folders, templates, and AI-readable rules."
 msgstr ""
 
-#: src/components/PublishToGitHubDialog.tsx
-msgid "Pick an owner"
-msgstr ""
-
 #: src/components/ShareReceiveDialog.tsx
 msgid "Pick the folder where you've cloned it."
 msgstr ""
@@ -6154,10 +6146,6 @@ msgstr ""
 msgid "yesterday"
 msgstr ""
 
-#: src/components/PublishToGitHubDialog.tsx
-msgid "you"
-msgstr ""
-
 #: src/components/TerminalGate.tsx
 msgid "You can also manage this in Settings."
 msgstr ""