Fix buffer is not defined warning

[mtmacdonald]

Sometimes seeing this in the console, in relation to PDF ...

[mtmacdonald]

Reopening this - I had to revert the "fix" in PR189. Status:

• My first preference would be for the @react-pdf project to stop depending on buffer. From #2758 - according to this comment there was a prior fix in PR1891, but later changes re-introduced the dependency on buffer. I also found another ticket #3225 that has been open some months.
• My second preference is to polyfill buffer. I am waiting for:
  • Either better Vite 8 guidelines on how: #21385
  • Or for blockers in vite-plugin-node-polyfills with Vite 8 to be resolved:
    • #144 security
    • The production build still shows Buffer is undefined even when using this package (latest version, with latest Vite 8 beta)
    • Minor console warnings #142

This task is blocked. But the app is functional (it concerns a runtime warning that does not impact using the app).

[CraigIntuety]

I know you mention everything runs as expected, but im getting increased cpu/ram usage to the point my fans kick in on my laptop because of the volume of console warnings.

[mtmacdonald]

I know you mention everything runs as expected, but im getting increased cpu/ram usage to the point my fans kick in on my laptop because of the volume of console warnings.

Hi @CraigIntuety - I think the best plan for the Buffer is not defined warning is if we add a manual polyfill, since vite-plugin-node-polyfills seems to be lagging a bit maintenance-wise when it comes to the upcoming Vite 8 release. To do that, I would probably look at upcoming Vite docs instructions in node polyfills. I'm not convinced this warning is related to performance, however. Generating the PDF the first time you load it happens in the dynamically in browser in a webworker, and make take some time/resources (probably depends on the size of the PDF you are generating, and the specs of your machine).

Going forward, this project has been acquired by Inkit - you can reach out to them directly if you need further support: https://www.inkit.com/contact-us.