From fe795effc0eaae660d219088e3b96b1ef70c50e4 Mon Sep 17 00:00:00 2001 From: Alexander Rybkin Date: Wed, 21 Oct 2026 00:30:41 -0700 Subject: [PATCH] link-rot: open the issue when the check times out too `report` ran on failure() only, but a job that hits timeout-minutes ends cancelled, not failed, so a hung weekly run went red with nobody told. It now runs on a failed or cancelled `links` result. A skipped one, which is what the repository guard gives a fork, still opens nothing; that is why the condition names the two results rather than testing != 'success'. --- .github/workflows/link-rot.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/link-rot.yml b/.github/workflows/link-rot.yml index 3929bfa..3211aae 100644 --- a/.github/workflows/link-rot.yml +++ b/.github/workflows/link-rot.yml @@ -43,7 +43,8 @@ jobs: # issue. Its own job so the write scope never sits next to the checker. report: needs: links - if: failure() && github.event_name == 'schedule' + # A job that hits timeout-minutes ends cancelled, not failed. Skipped (a fork) stays quiet. + if: always() && github.event_name == 'schedule' && (needs.links.result == 'failure' || needs.links.result == 'cancelled') runs-on: ubuntu-latest timeout-minutes: 5 permissions: