Make tone/sound/voice volume into defcustoms and set when changed

[robertmeta]

I wonder if Bart could help with this one, per Ramans
recommendation I want to get rid of the env values in
my config and make them defcustoms, but I think on
setting we need to call custom calls like

• tts_set_voice_volume -- etc.

Still considering the right way to do this.

[bartbunting]

I never really played with that before, but it shouldn't be too hard. I can take a look

[bartbunting]

Here is a patch against emacspeak.
It adds defcustoms to swiftmac-voices.el to set sound, tone and voice volume.
it adds additional defsubsts to dtk-speak.el to call the relevant tts functions in the speech server.
I put these here as it didn't seam unreasonable to think that these functions could be implemented in other speech servers. If this is wrong they could be moved elsewhere.

THoughts?
Uploading emacspeak-customize-swift-volume.patch…

[bartbunting]

I noticed in your latest changes you have not merged in the Patch. Just checking if that is intentional or you need something else from me?

[robertmeta]

Will do that now, was focused on getting in changes before the freeze for Emacspeak 60 -- now that I got those in just under the wire, will be looking at bigger stuff like this.

…

On Apr 27, 2024, at 17:44, bartbunting ***@***.***> wrote: I noticed in your latest changes you have not merged in the Patch. Just checking if that is intentional or you need something else from me? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Robert Melton ***@***.***

[robertmeta]

@bartbunting for stuff like this, I merge it into my clone of emacspeak first on https://github.com/robertmeta/emacspeak

[robertmeta]

@bartbunting patch link does not work for me.

[bartbunting]

Not sure why. I'm travelling at the moment so can't really fix it. But will have a look when I'm home tomorrow.

[bartbunting]

I have tried to upload patch again.
let me know how you get on.
emacspeak-customize-swift-volume.patch

[robertmeta]

That works -- gotta tweak it to apply with some changes.

…

On Apr 27, 2024, at 20:09, bartbunting ***@***.***> wrote: I have tried to upload patch again. let me know how you get on. emacspeak-customize-swift-volume.patch — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Robert Melton ***@***.***