Commit 56af625
committed
SmartArray, SmartArrayHtml: point @implements at the real interface
The foreach type hints annotated Iterator, but the classes implement
IteratorAggregate, so only PhpStorm (which is lenient about the
interface name) could use them. Now they annotate IteratorAggregate,
which PHPStan and Psalm read too.
Still one @implements line per object type rather than a union:
PhpStorm keeps only one object member per generic union, and the HTML
mode needs both SmartArrayHtml and SmartString to autocomplete. Verified
in PhpStorm 2025.3.1; the scalar union collapses to mixed in hovers,
which is cosmetic. Also collapses the raw side's five scalar lines into
one.1 parent 4e1f788 commit 56af625
2 files changed
Lines changed: 10 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
21 | 22 | | |
22 | 23 | | |
23 | 24 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
31 | 29 | | |
32 | 30 | | |
33 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
0 commit comments