-
|
I just updated crane and I don't know if this is the intended behavior, I think it wasn't like this before. This happens on both my MacOS machine and Linux (GHA runner). The dependencies are compiled once in github:ipetkov/crane at packages.cas-api =
let
commonArgs = {
src = craneLib.cleanCargoSource ./.;
strictDeps = true;
# FIXME: make tests pass and enable this again
doCheck = false;
CARGO_PROFILE = "release";
dontStrip = true;
inherit nativeBuildInputs buildInputs;
};
in
craneLib.buildPackage (
commonArgs
// {
cargoArtifacts = craneLib.buildDepsOnly commonArgs;
}
);Logs |
Beta Was this translation helpful? Give feedback.
Answered by
ipetkov
Dec 26, 2025
Replies: 1 comment 7 replies
-
|
pinning crane to v0.21.2 fixes this (not sure about 0.21.3 because there's a ld regression on macos) |
Beta Was this translation helpful? Give feedback.
7 replies
-
|
Hi @wonrax thanks for the report! Could you with the latest commit on Alternatively/additionally could you provide a(n ideally minimal) self-contained flake I can use to reproduce the issue? |
Beta Was this translation helpful? Give feedback.
-
|
@ipetkov i just updated this repo to reproduce the issue, please check https://github.com/wonrax/crane-reproduce-backtrace it shall recompile the |
Beta Was this translation helpful? Give feedback.
-
|
Thank you for the reproduction! I spotted the issue: sadly on Darwin builds the derivation is built in a directory with a different name between the final and deps-only derivations. Different strings in I've opened #950 which will effectively disable this behavior when building on Darwin hosts |
Beta Was this translation helpful? Give feedback.
Answer selected by
ipetkov
-
|
thanks, but this also happens for non-nixos linux distros (in my case it's ubuntu on GHA runner). this might indicate a bigger issue though, do you suspect anything else? |
Beta Was this translation helpful? Give feedback.
-
|
i just added a GHA workflow to reproduce this and updated crane to point to latest master you can see it still compiles the log crate three times |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the find! This is really unfortunate, I think the best way forward is to make this hook opt-in for the time being (that way callers can still set Should be fixed with #951 but let me know if that still doesn't work! cc @Popax21 for awareness |
Beta Was this translation helpful? Give feedback.
-
|
Unfortunate, but makes sense. I don't see a way to address this either beside maybe building out of a symlink with the same name for both derivations instead, e.g. |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank you for the reproduction! I spotted the issue: sadly on Darwin builds the derivation is built in a directory with a different name between the final and deps-only derivations. Different strings in
CARGO_BUILD_RUSTFLAGSresults in the cache being invalidated.I've opened #950 which will effectively disable this behavior when building on Darwin hosts