build failure

[holiman]

Got this trying to build today:

#33 33.02 [ 34%] Built target silkpre
#33 37.01 In file included from /evmone/include/evmmax/evmmax.hpp:6,
#33 37.01                  from /evmone/lib/evmone_precompiles/modexp.cpp:6:
#33 37.01 In function 'constexpr intx::div_result<intx::uint<N>, intx::uint<N> > intx::udivrem(const uint<N>&, const uint<N>&) [with unsigned int M = 320; unsigned int N = 128]',
#33 37.01     inlined from 'static constexpr UintT evmmax::ModArith<UintT>::compute_r_squared(const UintT&) [with UintT = intx::uint<128>]' at /evmone/include/evmmax/evmmax.hpp:46:29,
#33 37.01     inlined from 'constexpr evmmax::ModArith<UintT>::ModArith(const UintT&) [with UintT = intx::uint<128>]' at /evmone/include/evmmax/evmmax.hpp:59:38,
#33 37.01     inlined from 'UIntT {anonymous}::modexp_odd(const UIntT&, std::span<const unsigned char>, const UIntT&) [with UIntT = intx::uint<128>]' at /evmone/lib/evmone_precompiles/modexp.cpp:40:35,
#33 37.01     inlined from 'void {anonymous}::modexp_impl(std::span<const unsigned char>, std::span<const unsigned char>, std::span<const unsigned char>, uint8_t*) [with long unsigned int Size = 16]' at /evmone/lib/evmone_precompiles/modexp.cpp:115:28,
#33 37.01     inlined from 'void evmone::crypto::modexp(std::span<const unsigned char>, std::span<const unsigned char>, std::span<const unsigned char>, uint8_t*)' at /evmone/lib/evmone_precompiles/modexp.cpp:149:24:
#33 37.01 /root/.hunter/_Base/b194453/e447a03/11d6b08/Install/include/intx/intx.hpp:1536:34: error: array subscript 2 is outside array bounds of 'intx::uint<128> [1]' [-Werror=array-bounds=]
#33 37.01  1536 |     rw[na.num_divisor_words - 1] = un[na.num_divisor_words - 1] >> na.shift;
#33 37.01       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#33 37.01 /root/.hunter/_Base/b194453/e447a03/11d6b08/Install/include/intx/intx.hpp: In function 'void evmone::crypto::modexp(std::span<const unsigned char>, std::span<const unsigned char>, std::span<const unsigned char>, uint8_t*)':
#33 37.01 /root/.hunter/_Base/b194453/e447a03/11d6b08/Install/include/intx/intx.hpp:1532:13: note: at offset 16 into object 'r' of size 16
#33 37.01  1532 |     uint<N> r;
#33 37.01       |             ^
#33 37.01 In function 'constexpr intx::div_result<intx::uint<N>, intx::uint<N> > intx::udivrem(const uint<N>&, const uint<N>&) [with unsigned int M = 320; unsigned int N = 128]',
#33 37.01     inlined from 'static constexpr UintT evmmax::ModArith<UintT>::compute_r_squared(const UintT&) [with UintT = intx::uint<128>]' at /evmone/include/evmmax/evmmax.hpp:46:29,
#33 37.01     inlined from 'constexpr evmmax::ModArith<UintT>::ModArith(const UintT&) [with UintT = intx::uint<128>]' at /evmone/include/evmmax/evmmax.hpp:59:38,
#33 37.01     inlined from 'UIntT {anonymous}::modexp_odd(const UIntT&, std::span<const unsigned char>, const UIntT&) [with UIntT = intx::uint<128>]' at /evmone/lib/evmone_precompiles/modexp.cpp:40:35,
#33 37.01     inlined from 'void {anonymous}::modexp_impl(std::span<const unsigned char>, std::span<const unsigned char>, std::span<const unsigned char>, uint8_t*) [with long unsigned int Size = 16]' at /evmone/lib/evmone_precompiles/modexp.cpp:123:35,
#33 37.01     inlined from 'void evmone::crypto::modexp(std::span<const unsigned char>, std::span<const unsigned char>, std::span<const unsigned char>, uint8_t*)' at /evmone/lib/evmone_precompiles/modexp.cpp:149:24:
#33 37.01 /root/.hunter/_Base/b194453/e447a03/11d6b08/Install/include/intx/intx.hpp:1536:34: error: array subscript 2 is outside array bounds of 'intx::uint<128> [1]' [-Werror=array-bounds=]
#33 37.01  1536 |     rw[na.num_divisor_words - 1] = un[na.num_divisor_words - 1] >> na.shift;
#33 37.01       |     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#33 37.01 /root/.hunter/_Base/b194453/e447a03/11d6b08/Install/include/intx/intx.hpp: In function 'void evmone::crypto::modexp(std::span<const unsigned char>, std::span<const unsigned char>, std::span<const unsigned char>, uint8_t*)':
#33 37.01 /root/.hunter/_Base/b194453/e447a03/11d6b08/Install/include/intx/intx.hpp:1532:13: note: at offset 16 into object 'r' of size 16
#33 37.01  1532 |     uint<N> r;
#33 37.01       |             ^
#33 37.30 cc1plus: all warnings being treated as errors
#33 37.33 gmake[2]: *** [lib/evmone_precompiles/CMakeFiles/evmone_precompiles.dir/build.make:149: lib/evmone_precompiles/CMakeFiles/evmone_precompiles.dir/modexp.cpp.o] Error 1
#33 37.33 gmake[2]: *** Waiting for unfinished jobs....
#33 39.36 gmake[1]: *** [CMakeFiles/Makefile2:1060: lib/evmone_precompiles/CMakeFiles/evmone_precompiles.dir/all] Error 2
#33 39.36 gmake[1]: *** Waiting for unfinished jobs....
#33 57.17 [ 34%] Linking CXX executable ../../../bin/evmc
#33 57.78 [ 34%] Built target evmc-tool
#33 57.78 gmake: *** [Makefile:166: all] Error 2
#33 ERROR: process "/bin/sh -c cd evmone && cmake --build build --parallel" did not complete successfully: exit code: 2

Known issue? Am I doing something wrong? Cheers

[chfast]

Something worth taking look at because I got similar error from clang analyzer.

However, you should be able to build it without "warnings as errors". What is your cmake invocation?

[holiman]

This is how I build it, https://github.com/holiman/goevmlab/blob/master/docker/Dockerfile#L81

 RUN cd evmone && cmake -S . -B build -DEVMONE_TESTING=ON -DEVMONE_PRECOMPILES_SILKPRE=1
 RUN cd evmone && cmake --build build --parallel

[holiman]

However, you should be able to build it without "warnings as errors"

Tried a few variants, but it didn't quite fly. Any pointers on how to make that "punch through" ?

[holiman]

@chfast any ideas?

[pdobacz]

I've managed to find possibly related issues reported for gcc: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107699 and https://gcc.gnu.org/bugzilla/show_bug.cgi?id=107986 , the reported versions match up, but not exactly, with what works / doesn't work for me. CC @chfast, interesting about clang tho...

I tried pinning gcc version to 13 in your Dockerfile @holiman and it worked. Your bug happens on version 15, I use 11.4 locally and also see 11.2 in evmone CI, but I haven't been able to downgrade to 11 in your Dockerfile. I'm not entirely sure it's the proper way to do this, but hope this helps as a workaround:

In https://github.com/holiman/goevmlab/blob/master/docker/Dockerfile, part where evmone is built

...
RUN git clone https://github.com/ethereum/evmone.git --depth 1 --recurse-submodules
RUN apt-get install gcc-13 g++-13 -qy
RUN cd evmone && CC=/usr/bin/gcc-13 CXX=/usr/bin/g++-13 cmake -S . -B build -DEVMONE_TESTING=ON -DEVMONE_PRECOMPILES_SILKPRE=1
...

[chfast]

I planned to take a look directly, but I didn't have time so far. There seems to be multiple issues:

1. This seems to be an false positive, I've reported similar issues to GCC.
2. Despite the 1, evmone should not build with warnings-as-errors by default, i.e. the build should succeed despite the warning. I don't understand why it happens this way. Maybe try to set it directly to cmake: -DCMAKE_COMPILE_WARNING_AS_ERROR=0.
3. For the recent evmone you want -DEVMONE_PRECOMPILES_GMP=1 instead of -DEVMONE_PRECOMPILES_SILKPRE=1.

[holiman]

2. Despite the 1, evmone should not build with warnings-as-errors by default, i.e. the build should succeed despite the warning. I don't understand why it happens this way. Maybe try to set it directly to cmake: -DCMAKE_COMPILE_WARNING_AS_ERROR=0.

Yeah, tried it, doesn't seem to make it through to the compiler. The workaround of using gcc 13 seems to work though, thanks!

[chfast]

I figured out at least CMake configuration. This should allow building with GCC 15: #1351. The warnings are still present, but the build will progress.