Feat/getting a list of down sites#54
Open
kishore03109 wants to merge 3 commits into
Open
Conversation
dcshzj
approved these changes
Sep 26, 2023
dcshzj
left a comment
dcshzj
left a comment
Contributor
There was a problem hiding this comment.
Seems okay in general, but means we are reliant on Uptime Robot for being up-to-date with the list of domains. Are we guaranteed that we will always be monitoring the redirection domain for all sites?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses better uptime as a SOT for the list of live domains, and then uses it to grab the list of domains that