Skip to content

Use truncated and terminated return values correctly #16

Description

@clemens-fricke

Is your feature request related to a problem? Please describe.
When this package was first written, stable_baselines3 did not differentiate between different reasons for terminating an episode. But a few versions ago this changed. There are now two different episode termination variables:
terminated and truncated

I at some point saw this change and did a quick and dirty fix (I think) in the framework, but did not understand what the difference was back then. Now I just came by this part of the sb3 documentation that goes a little bit into the difference link to the docu part.

This needs to be implemented correctly so that we can give the agents the best possible information to train from.

Describe the solution you'd like
Adapt the correct variable to the end state if the episode is terminated.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomershelp wantedExtra attention is neededlow prioMaintianers wont prio this. But anybody is welcome to fix/implment this via a PR.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions